[inspector] Build inspector under v8_enable_inspector build flag.

src/v8.gyp

 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 16 matching lines @@
 
 {
   'variables': {
     'v8_code': 1,
     'v8_random_seed%': 314159265,
     'v8_vector_stores%': 0,
     'embed_script%': "",
     'warmup_script%': "",
     'v8_extra_library_files%': [],
     'v8_experimental_extra_library_files%': [],
+    'v8_enable_inspector%': 0,
     'mksnapshot_exec': '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)mksnapshot<(EXECUTABLE_SUFFIX)',
     'mkpeephole_exec': '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)mkpeephole<(EXECUTABLE_SUFFIX)',
   },
-  'includes': ['../gypfiles/toolchain.gypi', '../gypfiles/features.gypi'],
+  'includes': ['../gypfiles/toolchain.gypi', '../gypfiles/features.gypi', 'inspector/inspector.gypi'],
   'targets': [
     {
       'target_name': 'v8',
       'dependencies_traverse': 1,
       'dependencies': ['v8_maybe_snapshot'],
       'conditions': [
         ['want_separate_host_toolset==1', {
           'toolsets': ['host', 'target'],
         }, {
           'toolsets': ['target'],
@@ skipping 1671 matching lines @@
                 }],
               ],
             }],
           ],
         }, {  # v8_enable_i18n_support==0
           'sources!': [
             'i18n.cc',
             'i18n.h',
           ],
         }],
+        ['v8_enable_inspector==1', {
+          'sources': [
+            '<@(inspector_all_sources)'
+          ],
+          'dependencies': [

[Michael Achenbach, 2016/09/05 06:40:34]

Didn't see any gn equivalent of this in this CL. Not needed? Already landed?

[dgozman, 2016/09/06 17:37:35]

GN achieves this by having a v8_source_set("inspector"), which depends on
similar targets. In gyp we just add all inspector sources to v8_base (as
opposite to compiling them separately in source_set), thus deps move here.

[Michael Achenbach, 2016/09/06 18:27:22]

Acknowledged.

+            'inspector/inspector.gyp:protocol_generated_sources',
+            'inspector/inspector.gyp:inspector_injected_script',
+            'inspector/inspector.gyp:inspector_debugger_script',
+          ],
+          # TODO(dgozman): fix these warnings and enable them.
+          'msvs_disabled_warnings': [
+            4267,  # Truncation from size_t to int.
+            4305,  # Truncation from 'type1' to 'type2'.
+            4324,  # Struct padded due to declspec(align).
+            4714,  # Function marked forceinline not inlined.
+            4800,  # Value forced to bool.
+            4996,  # Deprecated function call.
+          ],
+          'cflags': [
+            '-Wno-zero-length-array',
+            '-Wno-shorten-64-to-32',
+            '-Wno-deprecated-declarations',
+          ],
+        }],
         ['OS=="win" and v8_enable_i18n_support==1', {
           'dependencies': [
             '<(icu_gyp_path):icudata',
           ],
         }],
       ],
     },
     {
       'target_name': 'v8_libbase',
       'type': 'static_library',
@@ skipping 673 matching lines @@
       'conditions': [
         ['want_separate_host_toolset_mkpeephole==1', {
           'toolsets': ['host'],
         }, {
           'toolsets': ['target'],
         }],
       ],
     },
   ],
 }