Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: build_overrides/v8.gni

Issue 2292053003: [inspector] Build inspector under v8_enable_inspector build flag. (Closed)
Patch Set: owners Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | gypfiles/standalone.gypi » ('j') | src/v8.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build_overrides/v8.gni
diff --git a/build_overrides/v8.gni b/build_overrides/v8.gni
index fc4a70e579b78debb972cf49cb68353f0040c254..09ea4570b02032ea70061051e880734ef39e2cec 100644
--- a/build_overrides/v8.gni
+++ b/build_overrides/v8.gni
@@ -11,10 +11,8 @@ if (is_android) {
import("//build/config/android/config.gni")
}
-if (((v8_current_cpu == "x86" ||
- v8_current_cpu == "x64" ||
- v8_current_cpu=="x87") &&
- (is_linux || is_mac)) ||
+if (((v8_current_cpu == "x86" || v8_current_cpu == "x64" ||
+ v8_current_cpu == "x87") && (is_linux || is_mac)) ||
(v8_current_cpu == "ppc64" && is_linux)) {
v8_enable_gdbjit_default = true
}
@@ -23,4 +21,12 @@ v8_imminent_deprecation_warnings_default = true
# Add simple extras solely for the purpose of the cctests.
v8_extra_library_files = [ "//test/cctest/test-extra.js" ]
-v8_experimental_extra_library_files = [ "//test/cctest/test-experimental-extra.js" ]
+v8_experimental_extra_library_files =
+ [ "//test/cctest/test-experimental-extra.js" ]
+
+declare_args() {
+ # Enable inspector. See include/v8-inspector.h.
+ v8_enable_inspector = false
+}
+
+v8_enable_inspector_override = v8_enable_inspector
Michael Achenbach 2016/09/02 07:21:28 The last line should land in chromium's v8.gni fir
dgozman 2016/09/02 14:05:59 Sure! I want to get a review of this patch first t
« no previous file with comments | « BUILD.gn ('k') | gypfiles/standalone.gypi » ('j') | src/v8.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698