Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: src/inspector/public/StringView.h

Issue 2292053003: [inspector] Build inspector under v8_enable_inspector build flag. (Closed)
Patch Set: owners Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/inspector/public/StringView.h
diff --git a/src/inspector/public/StringView.h b/src/inspector/public/StringView.h
deleted file mode 100644
index e8e2ba1a43bc008a0564010798ceacfaa3342c4c..0000000000000000000000000000000000000000
--- a/src/inspector/public/StringView.h
+++ /dev/null
@@ -1,42 +0,0 @@
-// Copyright 2016 the V8 project authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef V8_INSPECTOR_PUBLIC_STRINGVIEW_H_
-#define V8_INSPECTOR_PUBLIC_STRINGVIEW_H_
-
-#include <stdint.h>
-#include <cctype>
-
-namespace v8_inspector {
-
-class PLATFORM_EXPORT StringView {
- public:
- StringView() : m_is8Bit(true), m_length(0), m_characters8(nullptr) {}
-
- StringView(const uint8_t* characters, unsigned length)
- : m_is8Bit(true), m_length(length), m_characters8(characters) {}
-
- StringView(const uint16_t* characters, unsigned length)
- : m_is8Bit(false), m_length(length), m_characters16(characters) {}
-
- bool is8Bit() const { return m_is8Bit; }
- unsigned length() const { return m_length; }
-
- // TODO(dgozman): add DCHECK(m_is8Bit) to accessors once platform can be used
- // here.
- const uint8_t* characters8() const { return m_characters8; }
- const uint16_t* characters16() const { return m_characters16; }
-
- private:
- bool m_is8Bit;
- unsigned m_length;
- union {
- const uint8_t* m_characters8;
- const uint16_t* m_characters16;
- };
-};
-
-} // namespace v8_inspector
-
-#endif // V8_INSPECTOR_PUBLIC_STRINGVIEW_H_

Powered by Google App Engine
This is Rietveld 408576698