Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2291943002: Ensure clean layout for spellchecker (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure clean layout for spellchecker This patch is a preparation for hoisting the call sites of Document::updateStyleAndLayouIgnorePendingStylesheets from TextIterator and PlainText. BUG=590369 Committed: https://crrev.com/764af575f5a2a05c692fc4ffbedcc30a852cfb60 Cr-Commit-Position: refs/heads/master@{#415240}

Patch Set 1 #

Patch Set 2 : Fix broken test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -15 lines) Patch
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 7 chunks +47 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 22 (14 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-08-30 05:00:13 UTC) #6
yosin_UTC9
lgtm
4 years, 3 months ago (2016-08-30 06:09:48 UTC) #11
Xiaocheng
+tkent
4 years, 3 months ago (2016-08-30 06:52:04 UTC) #13
tkent
lgtm
4 years, 3 months ago (2016-08-30 06:58:35 UTC) #14
Xiaocheng
I just noticed that, currently every usage of DocumentLifecycle::DisallowTransitionScope is wrong... I'll fix the existing ...
4 years, 3 months ago (2016-08-30 07:15:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291943002/20001
4 years, 3 months ago (2016-08-30 08:05:11 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 08:09:06 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 08:11:11 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/764af575f5a2a05c692fc4ffbedcc30a852cfb60
Cr-Commit-Position: refs/heads/master@{#415240}

Powered by Google App Engine
This is Rietveld 408576698