Ensure clean layout for spellchecker

third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 153 matching lines @@
         for (Node& node : NodeTraversal::startsAt(toLocalFrame(frame)->document()->rootNode()))
             node.setAlreadySpellChecked(false);
     }
 }
 
 void SpellChecker::didBeginEditing(Element* element)
 {
     if (!isSpellCheckingEnabled())
         return;
 
+    // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+    // needs to be audited.  See http://crbug.com/590369 for more details.
+    // In the long term we should use idle time spell checker to prevent
+    // synchronous layout caused by spell checking (see crbug.com/517298).
+    frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
+    DocumentLifecycle::DisallowTransitionScope(frame().document()->lifecycle());
+
     bool isTextField = false;
     HTMLTextFormControlElement* enclosingHTMLTextFormControlElement = 0;
     if (!isHTMLTextFormControlElement(*element))
         enclosingHTMLTextFormControlElement = enclosingTextFormControl(Position::firstPositionInNode(element));
     element = enclosingHTMLTextFormControlElement ? enclosingHTMLTextFormControlElement : element;
     Element* parent = element;
     if (isHTMLTextFormControlElement(*element)) {
         HTMLTextFormControlElement* textControl = toHTMLTextFormControlElement(element);
         parent = textControl;
         element = textControl->innerEditorElement();
@@ skipping 124 matching lines @@
     spellCheckerClient().showSpellingUI(true);
 }
 
 void SpellChecker::clearMisspellingsAndBadGrammarForMovingParagraphs(const VisibleSelection& movingSelection)
 {
     removeMarkers(movingSelection, DocumentMarker::MisspellingMarkers());
 }
 
 void SpellChecker::markMisspellingsAndBadGrammarForMovingParagraphs(const VisibleSelection& movingSelection)
 {
+    // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+    // needs to be audited.  See http://crbug.com/590369 for more details.
+    // In the long term we should use idle time spell checker to prevent
+    // synchronous layout caused by spell checking (see crbug.com/517298).
+    frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
+    DocumentLifecycle::DisallowTransitionScope(frame().document()->lifecycle());
+
     markMisspellingsAndBadGrammar(movingSelection);
 }
 
 void SpellChecker::markMisspellingsAndBadGrammar(const VisibleSelection& selection)
 {
     if (!isSpellCheckingEnabled() || !isSpellCheckingEnabledFor(selection))
         return;
 
     const EphemeralRange& range = selection.toNormalizedEphemeralRange();
     if (range.isNull())
@@ skipping 152 matching lines @@
         return;
     }
     if (!request->isValid())
         return;
     if (request->rootEditableElement()->document() != frame().selection().document()) {
         // we ignore |request| made for another document.
         // "editing/spelling/spellcheck-sequencenum.html" and others reach here.
         return;
     }
 
+    // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets needs to be audited.
+    // see http://crbug.com/590369 for more details.
+    frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
     TextCheckingParagraph paragraph(request->checkingRange(), request->checkingRange());
 
     // Expand the range to encompass entire paragraphs, since text checking needs that much context.
     int selectionOffset = 0;
     int ambiguousBoundaryOffset = -1;
     bool selectionChanged = false;
     bool restoreSelectionAfterChange = false;
     bool adjustSelectionForParagraphBoundaries = false;
 
-    if (frame().selection().isCaret()) {
-        // Attempt to save the caret position so we can restore it later if needed
-        Position caretPosition = frame().selection().end();
-        selectionOffset = paragraph.offsetTo(caretPosition);
-        restoreSelectionAfterChange = true;
-        if (selectionOffset > 0 && (static_cast<unsigned>(selectionOffset) > paragraph.text().length() || paragraph.textCharAt(selectionOffset - 1) == newlineCharacter))
-            adjustSelectionForParagraphBoundaries = true;
-        if (selectionOffset > 0 && static_cast<unsigned>(selectionOffset) <= paragraph.text().length() && isAmbiguousBoundaryCharacter(paragraph.textCharAt(selectionOffset - 1)))
-            ambiguousBoundaryOffset = selectionOffset - 1;
-    }
-
-    // TODO(dglazkov): The use of updateStyleAndLayoutIgnorePendingStylesheets needs to be audited.
-    // see http://crbug.com/590369 for more details.
-    frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
-
     {
         DocumentLifecycle::DisallowTransitionScope(frame().document()->lifecycle());
 
+        if (frame().selection().isCaret()) {
+            // Attempt to save the caret position so we can restore it later if needed
+            Position caretPosition = frame().selection().end();
+            selectionOffset = paragraph.offsetTo(caretPosition);
+            restoreSelectionAfterChange = true;
+            if (selectionOffset > 0 && (static_cast<unsigned>(selectionOffset) > paragraph.text().length() || paragraph.textCharAt(selectionOffset - 1) == newlineCharacter))
+                adjustSelectionForParagraphBoundaries = true;
+            if (selectionOffset > 0 && static_cast<unsigned>(selectionOffset) <= paragraph.text().length() && isAmbiguousBoundaryCharacter(paragraph.textCharAt(selectionOffset - 1)))
+                ambiguousBoundaryOffset = selectionOffset - 1;
+        }
+
         for (unsigned i = 0; i < results.size(); i++) {
             int spellingRangeEndOffset = paragraph.checkingEnd();
             const TextCheckingResult* result = &results[i];
             int resultLocation = result->location + paragraph.checkingStart();
             int resultLength = result->length;
             bool resultEndsAtAmbiguousBoundary = ambiguousBoundaryOffset >= 0 && resultLocation + resultLength == ambiguousBoundaryOffset;
 
             // Only mark misspelling if:
             // 1. Current text checking isn't done for autocorrection.
             // 2. Result falls within spellingRange.
@@ skipping 155 matching lines @@
 }
 
 static bool shouldCheckOldSelection(const VisibleSelection& oldSelection)
 {
     if (!oldSelection.start().isConnected())
         return false;
     if (isSelectionInTextField(oldSelection))
         return false;
     if (isSelectionInTextArea(oldSelection))
         return true;
+
+    // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+    // needs to be audited.  See http://crbug.com/590369 for more details.
+    // In the long term we should use idle time spell checker to prevent
+    // synchronous layout caused by spell checking (see crbug.com/517298).
     oldSelection.start().document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
     return oldSelection.isContentEditable();
 }
 
 void SpellChecker::respondToChangedSelection(const VisibleSelection& oldSelection, FrameSelection::SetSelectionOptions options)
 {
     TRACE_EVENT0("blink", "SpellChecker::respondToChangedSelection");
     if (!isSpellCheckingEnabledFor(oldSelection))
         return;
 
     // When spell checking is off, existing markers disappear after the selection changes.
     if (!isSpellCheckingEnabled()) {
         frame().document()->markers().removeMarkers(DocumentMarker::Spelling);
         frame().document()->markers().removeMarkers(DocumentMarker::Grammar);
         return;
     }
 
     if (!(options & FrameSelection::CloseTyping))
         return;
     if (!shouldCheckOldSelection(oldSelection))
         return;
 
+    DocumentLifecycle::DisallowTransitionScope(frame().document()->lifecycle());
+
     VisibleSelection newAdjacentWords;
     const VisibleSelection newSelection = frame().selection().selection();
     if (isSelectionInTextFormControl(newSelection)) {
         const Position newStart = newSelection.start();
         newAdjacentWords.setWithoutValidation(HTMLTextFormControlElement::startOfWord(newStart), HTMLTextFormControlElement::endOfWord(newStart));
     } else {
         frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
         const bool caretBrowsing = frame().settings() && frame().settings()->caretBrowsingEnabled();
         if (newSelection.isContentEditable() || caretBrowsing) {
             const VisiblePosition newStart(newSelection.visibleStart());
@@ skipping 26 matching lines @@
 void SpellChecker::spellCheckAfterBlur()
 {
     if (!frame().selection().selection().isContentEditable())
         return;
 
     if (isSelectionInTextField(frame().selection().selection())) {
         // textFieldDidEndEditing() and textFieldDidBeginEditing() handle this.
         return;
     }
 
+    // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+    // needs to be audited.  See http://crbug.com/590369 for more details.
+    // In the long term we should use idle time spell checker to prevent
+    // synchronous layout caused by spell checking (see crbug.com/517298).
+    frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
+    DocumentLifecycle::DisallowTransitionScope(frame().document()->lifecycle());
+
     VisibleSelection empty;
     spellCheckOldSelection(frame().selection().selection(), empty);
 }
 
 void SpellChecker::spellCheckOldSelection(const VisibleSelection& oldSelection, const VisibleSelection& newAdjacentWords)
 {
     if (!isSpellCheckingEnabled())
         return;
 
     TRACE_EVENT0("blink", "SpellChecker::spellCheckOldSelection");
@@ skipping 178 matching lines @@
         VisiblePosition newParagraphStart = startOfNextParagraph(createVisiblePosition(paragraphEnd));
         paragraphStart = newParagraphStart.toParentAnchoredPosition();
         paragraphEnd = endOfParagraph(newParagraphStart).toParentAnchoredPosition();
         firstIteration = false;
         totalLengthProcessed += currentLength;
     }
     return std::make_pair(firstFoundItem, firstFoundOffset);
 }
 
 } // namespace blink