Cleanup call relationship in SpellChecker

Cleanup call relationship in SpellChecker

SpellChecker::markMisspellingsAndBadGrammar() is simutaneously called
from outside as a public function and used by other member functions of
SpellChecker as an internal procedure.

This patch cleans up the relations by making the function private and
introducing a public wrapper.

BUG=n/a
TEST=n/a; no behavior change

Committed: https://crrev.com/a133e77e34525837548a09091657b73c83fdcdab
Cr-Commit-Position: refs/heads/master@{#415236}

[Xiaocheng, 2016-08-30 03:50:30]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 03:52:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-30 03:53:38]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-08-30 03:53:39]

PTAL.

I think we don't need to hoist layout update calls from SpellChecker to its
callers. As long as we have idle time spellchecker, we don't need to perform any
synchronous layout for spellchecker anymore (maybe except for
SpellChecker::requestTextChecking).

[yosin_UTC9, 2016-08-30 04:55:53]

lgtm

[commit-bot: I haz the power, 2016-08-30 07:49:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 07:49:40]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-08-30 07:50:36]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-08-30 07:50:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 07:57:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-30 08:00:41]

Description was changed from

==========
Cleanup call relationship in SpellChecker

SpellChecker::markMisspellingsAndBadGrammar() is simutaneously called
from outside as a public function and used by other member functions of
SpellChecker as an internal procedure.

This patch cleans up the relations by making the function private and
introducing a public wrapper.

BUG=n/a
TEST=n/a; no behavior change
==========

to

==========
Cleanup call relationship in SpellChecker

SpellChecker::markMisspellingsAndBadGrammar() is simutaneously called
from outside as a public function and used by other member functions of
SpellChecker as an internal procedure.

This patch cleans up the relations by making the function private and
introducing a public wrapper.

BUG=n/a
TEST=n/a; no behavior change

Committed: https://crrev.com/a133e77e34525837548a09091657b73c83fdcdab
Cr-Commit-Position: refs/heads/master@{#415236}
==========

[commit-bot: I haz the power, 2016-08-30 08:00:42]

Patchset 2 (id:??) landed as
https://crrev.com/a133e77e34525837548a09091657b73c83fdcdab
Cr-Commit-Position: refs/heads/master@{#415236}