Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2297503002: Fix usage of DocumentLifecycle::DisallowTransitionScope (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix usage of DocumentLifecycle::DisallowTransitionScope BUG=590369 Committed: https://crrev.com/c3f340d2bc6cb50046f7808213d59d54fda67c0f Cr-Commit-Position: refs/heads/master@{#415273}

Patch Set 1 #

Patch Set 2 : Add missing layout update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 7 chunks +12 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-08-30 08:17:58 UTC) #4
tkent
lgtm
4 years, 3 months ago (2016-08-30 08:19:58 UTC) #5
Xiaocheng
Sorry, PTAL again... This patch does catch a missing layout update in SpellChecker::respondToChangedSelection...
4 years, 3 months ago (2016-08-30 08:50:35 UTC) #10
tkent
still lgtm
4 years, 3 months ago (2016-08-30 08:52:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2297503002/20001
4 years, 3 months ago (2016-08-30 11:48:57 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 11:53:37 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 11:55:08 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c3f340d2bc6cb50046f7808213d59d54fda67c0f
Cr-Commit-Position: refs/heads/master@{#415273}

Powered by Google App Engine
This is Rietveld 408576698