Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2291723002: Manually rename \<m_[0-9]... fields to help rewrite_to_chrome_style tool. (Closed)

Created:
4 years, 3 months ago by Łukasz Anforowicz
Modified:
4 years, 3 months ago
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, slimming-paint-reviews_chromium.org, blink-layers+watch_chromium.org, haraken, Rik, f(malita), Justin Novosad, blink-reviews-paint_chromium.org, blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis, dcheng, Kai Ninomiya
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manually rename \<m_[0-9]... fields to help rewrite_to_chrome_style tool. rewrite_to_chrome_style tool has trouble renaming \<m_[0-9]... fields, because |m_3dRenderingContext| shouldn't be renamed to |3d_rendering_context_| (the latter is not a valid C++ identifier). Therefore, this CL manually renames all \<m_[0-9]... fields under third_party/WebKit/Source, so that a digit will not appear as the first character of the name. A few extra fields have been renamed in core/paint/PaintLayer.h/.cpp for consistency between ...StatusDirty and is...Dirty. A few extra changes have been made to follow recent style changes (e.g. to prefer DCHECK over ASSERT in new code). BUG=641027 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029 Cr-Commit-Position: refs/heads/master@{#415320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -39 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayer.h View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 11 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Łukasz Anforowicz
kbr@, could you please take a look?
4 years, 3 months ago (2016-08-29 20:44:39 UTC) #5
Ken Russell (switch to Gerrit)
LGTM kainino@: this will conflict with your other patch which removes these persistent wrappers, but ...
4 years, 3 months ago (2016-08-29 21:44:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291723002/1
4 years, 3 months ago (2016-08-30 02:13:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/283712)
4 years, 3 months ago (2016-08-30 03:50:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291723002/1
4 years, 3 months ago (2016-08-30 14:11:04 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 16:49:10 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 16:51:02 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029
Cr-Commit-Position: refs/heads/master@{#415320}

Powered by Google App Engine
This is Rietveld 408576698