Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2291663002: Revert of Moved ambient lights out of SkLight's light array (Closed)

Created:
4 years, 3 months ago by vjiaoblack
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Moved ambient lights out of SkLight's light array (patchset #7 id:120001 of https://codereview.chromium.org/2287553002/ ) Reason for revert: Made Deigo's GM miss their ambient lights Original issue's description: > Moved ambient lights out of SkLight's light array > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2287553002 > > Committed: https://skia.googlesource.com/skia/+/8f98f0aa2d3f7571a890b916c7c4b5ee831e9686 TBR=robertphillips@google.com,djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/84cddf6fa7a2ee4a8163f99c9238d5fba6b49566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -87 lines) Patch
M gm/lightingshader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/lightingshader2.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M gm/lightingshaderbevel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shadowmaps.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkLights.h View 5 chunks +9 lines, -17 lines 0 comments Download
M samplecode/SampleBevel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleLighting.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleLitAtlas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkLightingShader.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M src/core/SkLights.cpp View 3 chunks +42 lines, -38 lines 0 comments Download
M src/core/SkShadowShader.cpp View 2 chunks +19 lines, -19 lines 0 comments Download
M src/utils/SkShadowPaintFilterCanvas.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/SerializationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
vjiaoblack
Created Revert of Moved ambient lights out of SkLight's light array
4 years, 3 months ago (2016-08-29 15:37:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291663002/1
4 years, 3 months ago (2016-08-29 15:38:00 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 15:38:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/84cddf6fa7a2ee4a8163f99c9238d5fba6b49566

Powered by Google App Engine
This is Rietveld 408576698