Replace CollectVariables with locals(), update callsites to walk locals instead

Replace CollectVariables with locals(), update callsites to walk locals instead

This additionally gets rid of old approach to global shortcuts.

BUG=v8:5209
Committed: https://crrev.com/1493bc8c8b5a2304a5f8fa8d49c8544025f554cf
Cr-Commit-Position: refs/heads/master@{#38980}

[Toon Verwaest, 2016-08-28 20:16:39]

verwaest@chromium.org changed reviewers:
+ ishell@chromium.org, neis@chromium.org

[Toon Verwaest, 2016-08-28 20:16:40]

ptal

[neis, 2016-08-29 08:45:58]

Do we still need VariableLocation::GLOBAL?

[neis, 2016-08-29 08:47:13]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 08:47:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 09:11:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 09:11:38]

Dry run: This issue passed the CQ dry run.

[neis, 2016-08-29 09:25:25]

Some minor comments.

https://codereview.chromium.org/2287173002/diff/20001/src/ast/scopeinfo.cc
File src/ast/scopeinfo.cc (right):

https://codereview.chromium.org/2287173002/diff/20001/src/ast/scopeinfo.cc#ne...
src/ast/scopeinfo.cc:17: // Collect variables.
Please make the comment more precise now.

https://codereview.chromium.org/2287173002/diff/20001/src/ast/scopeinfo.cc#ne...
src/ast/scopeinfo.cc:132: // them to the ScopeInfo object.
This should now also mention context locals.

https://codereview.chromium.org/2287173002/diff/20001/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2287173002/diff/20001/src/ast/scopes.cc#newco...
src/ast/scopes.cc:790: AllocateVariablesRecursively();
Nice comments ;)

https://codereview.chromium.org/2287173002/diff/20001/src/objects.h
File src/objects.h (left):

https://codereview.chromium.org/2287173002/diff/20001/src/objects.h#oldcode4418
src/objects.h:4418: 
Please update tools/gen-postmortem-metadata.py, which still refers to this
constant.

[Toon Verwaest, 2016-08-29 10:11:14]

Addressed comments

[neis, 2016-08-29 12:21:14]

lgtm

[Toon Verwaest, 2016-08-29 12:22:20]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-08-29 12:22:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 12:25:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 12:26:00]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/22794)

[Jarin, 2016-08-29 12:37:44]

jarin@chromium.org changed reviewers:
+ jarin@chromium.org

[Jarin, 2016-08-29 12:37:44]

lgtm for the AST graph builder.

[Toon Verwaest, 2016-08-29 12:47:10]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-08-29 12:47:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 12:49:23]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-29 12:49:42]

Description was changed from

==========
Replace CollectVariables with locals(), update callsites to walk locals instead

This additionally gets rid of old approach to global shortcuts.

BUG=v8:5209
==========

to

==========
Replace CollectVariables with locals(), update callsites to walk locals instead

This additionally gets rid of old approach to global shortcuts.

BUG=v8:5209

Committed: https://crrev.com/1493bc8c8b5a2304a5f8fa8d49c8544025f554cf
Cr-Commit-Position: refs/heads/master@{#38980}
==========

[commit-bot: I haz the power, 2016-08-29 12:49:44]

Patchset 5 (id:??) landed as
https://crrev.com/1493bc8c8b5a2304a5f8fa8d49c8544025f554cf
Cr-Commit-Position: refs/heads/master@{#38980}