src/runtime/runtime-scopes.cc - Issue 2287173002: Replace CollectVariables with locals(), update callsites to walk locals instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-scopes.cc

Issue 2287173002: Replace CollectVariables with locals(), update callsites to walk locals instead (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: restore undefined handling Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-scopes.cc

diff --git a/src/runtime/runtime-scopes.cc b/src/runtime/runtime-scopes.cc

index 26bfb29d9366b56ae1eefc4321dd065c3f10c78c..acdce8d1cf294af4b986d5b741cb5a4ef7f0b8d4 100644

--- a/src/runtime/runtime-scopes.cc

+++ b/src/runtime/runtime-scopes.cc

@@ -665,8 +665,6 @@ RUNTIME_FUNCTION(Runtime_NewScriptContext) {

Handle<Context> result =

isolate->factory()->NewScriptContext(closure, scope_info);

- result->InitializeGlobalSlots();

DCHECK(function->context() == isolate->context());

DCHECK(*global_object == result->global_object());

« no previous file with comments | « src/objects.h ('k') | tools/gen-postmortem-metadata.py » ('j') | no next file with comments »