src/crankshaft/hydrogen.cc - Issue 2287173002: Replace CollectVariables with locals(), update callsites to walk locals instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen.cc

Issue 2287173002: Replace CollectVariables with locals(), update callsites to walk locals instead (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: restore undefined handling Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/hydrogen.cc

diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc

index cc8dc59042e431de4087afb6e50b924a7f941963..eabf5199c080d0a80034dca00572cb564545b17d 100644

--- a/src/crankshaft/hydrogen.cc

+++ b/src/crankshaft/hydrogen.cc

@@ -10590,7 +10590,7 @@ void HOptimizedGraphBuilder::VisitDelete(UnaryOperation* expr) {

return ast_context()->ReturnInstruction(instr, expr->id());

} else if (proxy != NULL) {

Variable* var = proxy->var();

- if (var->IsUnallocatedOrGlobalSlot()) {

+ if (var->IsUnallocated()) {

Bailout(kDeleteWithGlobalVariable);

} else if (var->IsStackAllocated() || var->IsContextSlot()) {

// Result of deleting non-global variables is false. 'this' is not really

« no previous file with comments | « src/contexts.cc ('k') | src/crankshaft/typing.cc » ('j') | no next file with comments »