Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/compiler/ast-graph-builder.cc

Issue 2287173002: Replace CollectVariables with locals(), update callsites to walk locals instead (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: restore undefined handling Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/bootstrapper.cc ('k') | src/contexts.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/ast-graph-builder.h" 5 #include "src/compiler/ast-graph-builder.h"
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/compiler.h" 8 #include "src/compiler.h"
9 #include "src/compiler/ast-loop-assignment-analyzer.h" 9 #include "src/compiler/ast-loop-assignment-analyzer.h"
10 #include "src/compiler/control-builders.h" 10 #include "src/compiler/control-builders.h"
(...skipping 609 matching lines...) Expand 10 before | Expand all | Expand 10 after
620 if (FLAG_trace_environment_liveness) { 620 if (FLAG_trace_environment_liveness) {
621 OFStream os(stdout); 621 OFStream os(stdout);
622 liveness_analyzer()->Print(os); 622 liveness_analyzer()->Print(os);
623 } 623 }
624 } 624 }
625 625
626 626
627 // Gets the bailout id just before reading a variable proxy, but only for 627 // Gets the bailout id just before reading a variable proxy, but only for
628 // unallocated variables. 628 // unallocated variables.
629 static BailoutId BeforeId(VariableProxy* proxy) { 629 static BailoutId BeforeId(VariableProxy* proxy) {
630 return proxy->var()->IsUnallocatedOrGlobalSlot() ? proxy->BeforeId() 630 return proxy->var()->IsUnallocated() ? proxy->BeforeId() : BailoutId::None();
631 : BailoutId::None();
632 } 631 }
633 632
634 static const char* GetDebugParameterName(Zone* zone, DeclarationScope* scope, 633 static const char* GetDebugParameterName(Zone* zone, DeclarationScope* scope,
635 int index) { 634 int index) {
636 #if DEBUG 635 #if DEBUG
637 const AstRawString* name = scope->parameter(index)->raw_name(); 636 const AstRawString* name = scope->parameter(index)->raw_name();
638 if (name && name->length() > 0) { 637 if (name && name->length() > 0) {
639 char* data = zone->NewArray<char>(name->length() + 1); 638 char* data = zone->NewArray<char>(name->length() + 1);
640 data[name->length()] = 0; 639 data[name->length()] = 0;
641 memcpy(data, name->raw_data(), name->length()); 640 memcpy(data, name->raw_data(), name->length());
(...skipping 3692 matching lines...) Expand 10 before | Expand all | Expand 10 after
4334 // Phi does not exist yet, introduce one. 4333 // Phi does not exist yet, introduce one.
4335 value = NewPhi(inputs, value, control); 4334 value = NewPhi(inputs, value, control);
4336 value->ReplaceInput(inputs - 1, other); 4335 value->ReplaceInput(inputs - 1, other);
4337 } 4336 }
4338 return value; 4337 return value;
4339 } 4338 }
4340 4339
4341 } // namespace compiler 4340 } // namespace compiler
4342 } // namespace internal 4341 } // namespace internal
4343 } // namespace v8 4342 } // namespace v8
OLDNEW
« no previous file with comments | « src/bootstrapper.cc ('k') | src/contexts.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698