[interpreter] Make the comparison bytecode handlers collect type feedback.

[interpreter] Make the comparison bytecode handlers collect type feedback.

BUG=v8:5273
Committed: https://crrev.com/708f80d243d108220d5e5c9b1dedc1217c73db9c
Cr-Commit-Position: refs/heads/master@{#39006}

[epertoso, 2016-08-29 10:33:46]

Patchset #2 (id:20001) has been deleted

[epertoso, 2016-08-29 10:34:39]

Description was changed from

==========
[interpreter] Make the comparison bytecode handlers collect type feedback.

BUG=
==========

to

==========
[interpreter] Make the comparison bytecode handlers collect type feedback.

BUG=v8:5273
==========

[epertoso, 2016-08-29 10:34:39]

epertoso@chromium.org changed reviewers:
+ bmeurer@chromium.org, mythria@chromium.org

[epertoso, 2016-08-29 10:34:39]

epertoso@chromium.org changed required reviewers:
+ mythria@chromium.org

[epertoso, 2016-08-29 10:34:47]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 10:34:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 10:58:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 10:58:01]

Dry run: Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)

[epertoso, 2016-08-29 11:55:50]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 11:56:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 12:25:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 12:25:23]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-08-30 03:47:43]

Nice work. LGTM.

[mythria, 2016-08-30 08:09:29]

Thanks for doing this and also binary ops. lgtm.

https://codereview.chromium.org/2286273002/diff/60001/src/globals.h
File src/globals.h (right):

https://codereview.chromium.org/2286273002/diff/60001/src/globals.h#newcode1159
src/globals.h:1159: // TODO(epertoso): consider unifying this with
BinaryOperationFeedback.
Is there any reason we don't do it now?

[epertoso, 2016-08-30 10:18:17]

On 2016/08/30 08:09:29, mythria wrote:
> Thanks for doing this and also binary ops. lgtm.
> 
> https://codereview.chromium.org/2286273002/diff/60001/src/globals.h
> File src/globals.h (right):
> 
>
https://codereview.chromium.org/2286273002/diff/60001/src/globals.h#newcode1159
> src/globals.h:1159: // TODO(epertoso): consider unifying this with
> BinaryOperationFeedback.
> Is there any reason we don't do it now?

We are thinking of a few alternatives, e.g. moving the BinaryOperationHint and
CompareOperationHint out of src/compiler.

[epertoso, 2016-08-30 10:18:27]

The CQ bit was checked by epertoso@chromium.org

[commit-bot: I haz the power, 2016-08-30 10:18:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 10:21:06]

Description was changed from

==========
[interpreter] Make the comparison bytecode handlers collect type feedback.

BUG=v8:5273
==========

to

==========
[interpreter] Make the comparison bytecode handlers collect type feedback.

BUG=v8:5273
==========

[commit-bot: I haz the power, 2016-08-30 10:21:07]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-08-30 10:21:48]

Description was changed from

==========
[interpreter] Make the comparison bytecode handlers collect type feedback.

BUG=v8:5273
==========

to

==========
[interpreter] Make the comparison bytecode handlers collect type feedback.

BUG=v8:5273

Committed: https://crrev.com/708f80d243d108220d5e5c9b1dedc1217c73db9c
Cr-Commit-Position: refs/heads/master@{#39006}
==========

[commit-bot: I haz the power, 2016-08-30 10:21:49]

Patchset 3 (id:??) landed as
https://crrev.com/708f80d243d108220d5e5c9b1dedc1217c73db9c
Cr-Commit-Position: refs/heads/master@{#39006}