Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/bytecode_expectations/BasicLoops.golden

Issue 2286273002: [interpreter] Make the comparison bytecode handlers collect type feedback. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/globals.h ('K') | « test/cctest/interpreter/bytecode_expectations/BasicBlockToBoolean.golden ('k') | test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode_expectations/BasicLoops.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden b/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden
index 6dcd2692af9c1e8b42c0ac98582a464893c1a181..12e135deca7bb0328e262be947f0d79a8d677b60 100644
--- a/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden
+++ b/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden
@@ -65,7 +65,7 @@ snippet: "
"
frame size: 2
parameter count: 1
-bytecode array length: 49
+bytecode array length: 52
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
@@ -73,23 +73,23 @@ bytecodes: [
/* 53 S> */ B(LdaSmi), U8(1),
B(Star), R(1),
/* 65 S> */ B(LdaSmi), U8(10),
- /* 65 E> */ B(TestLessThan), R(0),
- B(JumpIfFalse), U8(34),
+ /* 65 E> */ B(TestLessThan), R(0), U8(1),
+ B(JumpIfFalse), U8(36),
/* 56 E> */ B(StackCheck),
/* 75 S> */ B(LdaSmi), U8(12),
- B(Mul), R(1), U8(1),
+ B(Mul), R(1), U8(2),
B(Star), R(1),
- /* 89 S> */ B(AddSmi), U8(1), R(0), U8(2),
+ /* 89 S> */ B(AddSmi), U8(1), R(0), U8(3),
B(Star), R(0),
/* 102 S> */ B(LdaSmi), U8(3),
- /* 108 E> */ B(TestEqual), R(0),
+ /* 108 E> */ B(TestEqual), R(0), U8(4),
B(JumpIfFalse), U8(4),
- /* 114 S> */ B(Jump), U8(10),
+ /* 114 S> */ B(Jump), U8(11),
/* 126 S> */ B(LdaSmi), U8(4),
- /* 132 E> */ B(TestEqual), R(0),
+ /* 132 E> */ B(TestEqual), R(0), U8(5),
B(JumpIfFalse), U8(4),
/* 138 S> */ B(Jump), U8(4),
- B(Jump), U8(-36),
+ B(Jump), U8(-39),
/* 147 S> */ B(Ldar), R(1),
/* 157 S> */ B(Return),
]
@@ -113,35 +113,35 @@ snippet: "
"
frame size: 1
parameter count: 1
-bytecode array length: 55
+bytecode array length: 60
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
B(Star), R(0),
/* 45 E> */ B(StackCheck),
/* 62 S> */ B(LdaZero),
- /* 68 E> */ B(TestLessThan), R(0),
+ /* 68 E> */ B(TestLessThan), R(0), U8(1),
B(JumpIfFalse), U8(4),
- /* 73 S> */ B(Jump), U8(40),
+ /* 73 S> */ B(Jump), U8(44),
/* 85 S> */ B(LdaSmi), U8(3),
- /* 91 E> */ B(TestEqual), R(0),
+ /* 91 E> */ B(TestEqual), R(0), U8(2),
B(JumpIfFalse), U8(4),
- /* 97 S> */ B(Jump), U8(34),
+ /* 97 S> */ B(Jump), U8(37),
/* 106 S> */ B(LdaSmi), U8(4),
- /* 112 E> */ B(TestEqual), R(0),
+ /* 112 E> */ B(TestEqual), R(0), U8(3),
B(JumpIfFalse), U8(4),
- /* 118 S> */ B(Jump), U8(26),
+ /* 118 S> */ B(Jump), U8(28),
/* 127 S> */ B(LdaSmi), U8(10),
- /* 133 E> */ B(TestEqual), R(0),
+ /* 133 E> */ B(TestEqual), R(0), U8(4),
B(JumpIfFalse), U8(4),
- /* 140 S> */ B(Jump), U8(16),
+ /* 140 S> */ B(Jump), U8(17),
/* 152 S> */ B(LdaSmi), U8(5),
- /* 158 E> */ B(TestEqual), R(0),
+ /* 158 E> */ B(TestEqual), R(0), U8(5),
B(JumpIfFalse), U8(4),
/* 164 S> */ B(Jump), U8(10),
- /* 173 S> */ B(AddSmi), U8(1), R(0), U8(1),
+ /* 173 S> */ B(AddSmi), U8(1), R(0), U8(6),
B(Star), R(0),
- B(Jump), U8(-46),
+ B(Jump), U8(-51),
/* 186 S> */ B(Ldar), R(0),
/* 196 S> */ B(Return),
]
@@ -165,24 +165,24 @@ snippet: "
"
frame size: 1
parameter count: 1
-bytecode array length: 39
+bytecode array length: 41
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
B(Star), R(0),
/* 45 E> */ B(StackCheck),
/* 71 S> */ B(LdaSmi), U8(3),
- /* 71 E> */ B(TestLessThan), R(0),
- B(JumpIfFalse), U8(19),
+ /* 71 E> */ B(TestLessThan), R(0), U8(1),
+ B(JumpIfFalse), U8(20),
/* 62 E> */ B(StackCheck),
/* 82 S> */ B(LdaSmi), U8(2),
- /* 88 E> */ B(TestEqual), R(0),
+ /* 88 E> */ B(TestEqual), R(0), U8(2),
B(JumpIfFalse), U8(4),
/* 94 S> */ B(Jump), U8(10),
- /* 105 S> */ B(AddSmi), U8(1), R(0), U8(1),
+ /* 105 S> */ B(AddSmi), U8(1), R(0), U8(3),
B(Star), R(0),
- B(Jump), U8(-21),
- /* 122 S> */ B(AddSmi), U8(1), R(0), U8(2),
+ B(Jump), U8(-23),
+ /* 122 S> */ B(AddSmi), U8(1), R(0), U8(4),
B(Star), R(0),
/* 135 S> */ B(Jump), U8(2),
/* 144 S> */ B(Ldar), R(0),
@@ -242,7 +242,7 @@ snippet: "
"
frame size: 2
parameter count: 1
-bytecode array length: 47
+bytecode array length: 50
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
@@ -254,18 +254,18 @@ bytecodes: [
B(Mul), R(1), U8(1),
B(Star), R(1),
/* 77 S> */ B(LdaSmi), U8(5),
- /* 83 E> */ B(TestEqual), R(0),
+ /* 83 E> */ B(TestEqual), R(0), U8(2),
B(JumpIfFalse), U8(4),
- /* 89 S> */ B(Jump), U8(22),
+ /* 89 S> */ B(Jump), U8(24),
/* 98 S> */ B(LdaSmi), U8(6),
- /* 104 E> */ B(TestEqual), R(0),
+ /* 104 E> */ B(TestEqual), R(0), U8(3),
B(JumpIfFalse), U8(4),
/* 110 S> */ B(Jump), U8(8),
- /* 122 S> */ B(AddSmi), U8(1), R(0), U8(2),
+ /* 122 S> */ B(AddSmi), U8(1), R(0), U8(4),
B(Star), R(0),
/* 144 S> */ B(LdaSmi), U8(10),
- /* 144 E> */ B(TestLessThan), R(0),
- B(JumpIfTrue), U8(-34),
+ /* 144 E> */ B(TestLessThan), R(0), U8(5),
+ B(JumpIfTrue), U8(-37),
/* 151 S> */ B(Ldar), R(1),
/* 161 S> */ B(Return),
]
@@ -321,7 +321,7 @@ snippet: "
"
frame size: 2
parameter count: 1
-bytecode array length: 41
+bytecode array length: 43
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
@@ -333,13 +333,13 @@ bytecodes: [
B(Mul), R(1), U8(1),
B(Star), R(1),
/* 77 S> */ B(LdaSmi), U8(5),
- /* 83 E> */ B(TestEqual), R(0),
+ /* 83 E> */ B(TestEqual), R(0), U8(2),
B(JumpIfFalse), U8(4),
- /* 89 S> */ B(Jump), U8(16),
- /* 98 S> */ B(AddSmi), U8(1), R(0), U8(2),
+ /* 89 S> */ B(Jump), U8(17),
+ /* 98 S> */ B(AddSmi), U8(1), R(0), U8(3),
B(Star), R(0),
/* 111 S> */ B(LdaSmi), U8(6),
- /* 117 E> */ B(TestEqual), R(0),
+ /* 117 E> */ B(TestEqual), R(0), U8(4),
B(JumpIfFalse), U8(4),
/* 123 S> */ B(Jump), U8(2),
/* 150 S> */ B(Ldar), R(1),
@@ -363,7 +363,7 @@ snippet: "
"
frame size: 2
parameter count: 1
-bytecode array length: 43
+bytecode array length: 45
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
@@ -375,16 +375,16 @@ bytecodes: [
B(Mul), R(1), U8(1),
B(Star), R(1),
/* 77 S> */ B(LdaSmi), U8(5),
- /* 83 E> */ B(TestEqual), R(0),
+ /* 83 E> */ B(TestEqual), R(0), U8(2),
B(JumpIfFalse), U8(4),
- /* 89 S> */ B(Jump), U8(18),
- /* 98 S> */ B(AddSmi), U8(1), R(0), U8(2),
+ /* 89 S> */ B(Jump), U8(19),
+ /* 98 S> */ B(AddSmi), U8(1), R(0), U8(3),
B(Star), R(0),
/* 111 S> */ B(LdaSmi), U8(6),
- /* 117 E> */ B(TestEqual), R(0),
+ /* 117 E> */ B(TestEqual), R(0), U8(4),
B(JumpIfFalse), U8(4),
/* 123 S> */ B(Jump), U8(2),
- B(Jump), U8(-30),
+ B(Jump), U8(-32),
/* 149 S> */ B(Ldar), R(1),
/* 159 S> */ B(Return),
]
@@ -404,23 +404,23 @@ snippet: "
"
frame size: 1
parameter count: 1
-bytecode array length: 31
+bytecode array length: 33
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
B(Star), R(0),
/* 45 E> */ B(StackCheck),
/* 58 S> */ B(LdaSmi), U8(1),
- /* 64 E> */ B(TestEqual), R(0),
+ /* 64 E> */ B(TestEqual), R(0), U8(1),
B(JumpIfFalse), U8(4),
- /* 70 S> */ B(Jump), U8(18),
+ /* 70 S> */ B(Jump), U8(19),
/* 79 S> */ B(LdaSmi), U8(2),
- /* 85 E> */ B(TestEqual), R(0),
+ /* 85 E> */ B(TestEqual), R(0), U8(2),
B(JumpIfFalse), U8(4),
/* 91 S> */ B(Jump), U8(8),
- /* 103 S> */ B(AddSmi), U8(1), R(0), U8(1),
+ /* 103 S> */ B(AddSmi), U8(1), R(0), U8(3),
B(Star), R(0),
- B(Jump), U8(-23),
+ B(Jump), U8(-25),
B(LdaUndefined),
/* 116 S> */ B(Return),
]
@@ -439,23 +439,23 @@ snippet: "
"
frame size: 1
parameter count: 1
-bytecode array length: 31
+bytecode array length: 33
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 47 S> */ B(LdaZero),
B(Star), R(0),
/* 34 E> */ B(StackCheck),
/* 56 S> */ B(LdaSmi), U8(1),
- /* 62 E> */ B(TestEqual), R(0),
+ /* 62 E> */ B(TestEqual), R(0), U8(1),
B(JumpIfFalse), U8(4),
- /* 68 S> */ B(Jump), U8(18),
+ /* 68 S> */ B(Jump), U8(19),
/* 77 S> */ B(LdaSmi), U8(2),
- /* 83 E> */ B(TestEqual), R(0),
+ /* 83 E> */ B(TestEqual), R(0), U8(2),
B(JumpIfFalse), U8(4),
/* 89 S> */ B(Jump), U8(8),
- /* 101 S> */ B(AddSmi), U8(1), R(0), U8(1),
+ /* 101 S> */ B(AddSmi), U8(1), R(0), U8(3),
B(Star), R(0),
- B(Jump), U8(-23),
+ B(Jump), U8(-25),
B(LdaUndefined),
/* 114 S> */ B(Return),
]
@@ -474,23 +474,23 @@ snippet: "
"
frame size: 1
parameter count: 1
-bytecode array length: 31
+bytecode array length: 33
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
B(Star), R(0),
/* 45 E> */ B(StackCheck),
/* 68 S> */ B(LdaSmi), U8(1),
- /* 74 E> */ B(TestEqual), R(0),
+ /* 74 E> */ B(TestEqual), R(0), U8(2),
B(JumpIfFalse), U8(4),
- /* 80 S> */ B(Jump), U8(18),
+ /* 80 S> */ B(Jump), U8(19),
/* 89 S> */ B(LdaSmi), U8(2),
- /* 95 E> */ B(TestEqual), R(0),
+ /* 95 E> */ B(TestEqual), R(0), U8(3),
B(JumpIfFalse), U8(4),
/* 101 S> */ B(Jump), U8(2),
/* 55 S> */ B(AddSmi), U8(1), R(0), U8(1),
B(Star), R(0),
- B(Jump), U8(-23),
+ B(Jump), U8(-25),
B(LdaUndefined),
/* 113 S> */ B(Return),
]
@@ -508,23 +508,23 @@ snippet: "
"
frame size: 1
parameter count: 1
-bytecode array length: 31
+bytecode array length: 33
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 47 S> */ B(LdaZero),
B(Star), R(0),
/* 34 E> */ B(StackCheck),
/* 66 S> */ B(LdaSmi), U8(1),
- /* 72 E> */ B(TestEqual), R(0),
+ /* 72 E> */ B(TestEqual), R(0), U8(2),
B(JumpIfFalse), U8(4),
- /* 78 S> */ B(Jump), U8(18),
+ /* 78 S> */ B(Jump), U8(19),
/* 87 S> */ B(LdaSmi), U8(2),
- /* 93 E> */ B(TestEqual), R(0),
+ /* 93 E> */ B(TestEqual), R(0), U8(3),
B(JumpIfFalse), U8(4),
/* 99 S> */ B(Jump), U8(2),
/* 53 S> */ B(AddSmi), U8(1), R(0), U8(1),
B(Star), R(0),
- B(Jump), U8(-23),
+ B(Jump), U8(-25),
B(LdaUndefined),
/* 111 S> */ B(Return),
]
@@ -543,7 +543,7 @@ snippet: "
"
frame size: 2
parameter count: 1
-bytecode array length: 32
+bytecode array length: 33
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
@@ -551,15 +551,15 @@ bytecodes: [
/* 58 S> */ B(LdaZero),
B(Star), R(1),
/* 63 S> */ B(LdaSmi), U8(100),
- /* 63 E> */ B(TestLessThan), R(1),
+ /* 63 E> */ B(TestLessThan), R(1), U8(1),
B(JumpIfFalse), U8(19),
/* 45 E> */ B(StackCheck),
- /* 85 S> */ B(AddSmi), U8(1), R(0), U8(2),
+ /* 85 S> */ B(AddSmi), U8(1), R(0), U8(3),
B(Star), R(0),
/* 98 S> */ B(Jump), U8(2),
- /* 72 S> */ B(AddSmi), U8(1), R(1), U8(1),
+ /* 72 S> */ B(AddSmi), U8(1), R(1), U8(2),
B(Star), R(1),
- B(Jump), U8(-21),
+ B(Jump), U8(-22),
B(LdaUndefined),
/* 110 S> */ B(Return),
]
@@ -639,7 +639,7 @@ snippet: "
"
frame size: 2
parameter count: 1
-bytecode array length: 33
+bytecode array length: 34
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
@@ -650,13 +650,13 @@ bytecodes: [
/* 76 S> */ B(AddSmi), U8(1), R(0), U8(2),
B(Star), R(0),
/* 89 S> */ B(LdaSmi), U8(20),
- /* 95 E> */ B(TestEqual), R(0),
+ /* 95 E> */ B(TestEqual), R(0), U8(3),
B(JumpIfFalse), U8(4),
/* 102 S> */ B(Jump), U8(10),
/* 69 S> */ B(Ldar), R(1),
B(Inc), U8(1),
B(Star), R(1),
- B(Jump), U8(-21),
+ B(Jump), U8(-22),
/* 112 S> */ B(Ldar), R(0),
/* 122 S> */ B(Return),
]
« src/globals.h ('K') | « test/cctest/interpreter/bytecode_expectations/BasicBlockToBoolean.golden ('k') | test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698