Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: src/globals.h

Issue 2286273002: [interpreter] Make the comparison bytecode handlers collect type feedback. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/type-hint-analyzer.cc ('k') | src/interpreter/bytecode-array-builder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_GLOBALS_H_ 5 #ifndef V8_GLOBALS_H_
6 #define V8_GLOBALS_H_ 6 #define V8_GLOBALS_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 1138 matching lines...) Expand 10 before | Expand all | Expand 10 after
1149 1149
1150 // Type feedback is encoded in such a way that, we can combine the feedback 1150 // Type feedback is encoded in such a way that, we can combine the feedback
1151 // at different points by performing an 'OR' operation. Type feedback moves 1151 // at different points by performing an 'OR' operation. Type feedback moves
1152 // to a more generic type when we combine feedback. 1152 // to a more generic type when we combine feedback.
1153 // kSignedSmall -> kNumber -> kAny 1153 // kSignedSmall -> kNumber -> kAny
1154 class BinaryOperationFeedback { 1154 class BinaryOperationFeedback {
1155 public: 1155 public:
1156 enum { kNone = 0x00, kSignedSmall = 0x01, kNumber = 0x3, kAny = 0x7 }; 1156 enum { kNone = 0x00, kSignedSmall = 0x01, kNumber = 0x3, kAny = 0x7 };
1157 }; 1157 };
1158 1158
1159 // TODO(epertoso): consider unifying this with BinaryOperationFeedback.
mythria 2016/08/30 08:09:29 Is there any reason we don't do it now?
1160 class CompareOperationFeedback {
1161 public:
1162 enum { kNone = 0x00, kSignedSmall = 0x01, kNumber = 0x3, kAny = 0x7 };
1163 };
1164
1159 } // namespace internal 1165 } // namespace internal
1160 } // namespace v8 1166 } // namespace v8
1161 1167
1162 namespace i = v8::internal; 1168 namespace i = v8::internal;
1163 1169
1164 #endif // V8_GLOBALS_H_ 1170 #endif // V8_GLOBALS_H_
OLDNEW
« no previous file with comments | « src/compiler/type-hint-analyzer.cc ('k') | src/interpreter/bytecode-array-builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698