Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/bytecode_expectations/ForOf.golden

Issue 2286273002: [interpreter] Make the comparison bytecode handlers collect type feedback. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/globals.h ('K') | « test/cctest/interpreter/bytecode_expectations/ForIn.golden ('k') | test/cctest/interpreter/bytecode_expectations/Generators.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode_expectations/ForOf.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/ForOf.golden b/test/cctest/interpreter/bytecode_expectations/ForOf.golden
index 454ea54c9362feb46f2dcf6166b37c236f08327e..50dc99e7333e08b4f6b9713f92cf032e8920c30a 100644
--- a/test/cctest/interpreter/bytecode_expectations/ForOf.golden
+++ b/test/cctest/interpreter/bytecode_expectations/ForOf.golden
@@ -13,7 +13,7 @@ snippet: "
"
frame size: 15
parameter count: 1
-bytecode array length: 268
+bytecode array length: 275
bytecodes: [
/* 30 E> */ B(StackCheck),
B(LdaZero),
@@ -44,14 +44,14 @@ bytecodes: [
B(LdaZero),
B(Star), R(4),
B(Jump), U8(-49),
- B(Jump), U8(34),
+ B(Jump), U8(35),
B(Star), R(13),
B(Ldar), R(closure),
B(CreateCatchContext), R(13), U8(5),
B(Star), R(12),
B(PushContext), R(8),
B(LdaSmi), U8(2),
- B(TestEqualStrict), R(4),
+ B(TestEqualStrict), R(4), U8(13),
B(JumpIfFalse), U8(6),
B(LdaSmi), U8(1),
B(Star), R(4),
@@ -67,24 +67,24 @@ bytecodes: [
B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), R(0), U8(0),
B(Star), R(11),
B(LdaZero),
- B(TestEqualStrict), R(4),
- B(JumpIfTrue), U8(116),
+ B(TestEqualStrict), R(4), U8(14),
+ B(JumpIfTrue), U8(120),
B(LdaUndefined),
- B(TestEqualStrict), R(2),
- B(JumpIfTrue), U8(111),
- B(LdrNamedProperty), R(2), U8(6), U8(13), R(6),
+ B(TestEqualStrict), R(2), U8(15),
+ B(JumpIfTrue), U8(114),
+ B(LdrNamedProperty), R(2), U8(6), U8(16), R(6),
B(LdaNull),
- B(TestEqual), R(6),
+ B(TestEqual), R(6), U8(18),
B(JumpIfFalse), U8(4),
- B(Jump), U8(99),
+ B(Jump), U8(101),
B(LdaSmi), U8(1),
- B(TestEqualStrict), R(4),
- B(JumpIfFalse), U8(68),
+ B(TestEqualStrict), R(4), U8(19),
+ B(JumpIfFalse), U8(69),
B(Ldar), R(6),
B(TypeOf),
B(Star), R(12),
B(LdaConstant), U8(7),
- B(TestEqualStrict), R(12),
+ B(TestEqualStrict), R(12), U8(20),
B(JumpIfFalse), U8(4),
B(Jump), U8(18),
B(Wide), B(LdaSmi), U16(129),
@@ -117,7 +117,7 @@ bytecodes: [
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(7), U8(1),
B(CallRuntime), U16(Runtime::kInterpreterSetPendingMessage), R(11), U8(1),
B(LdaZero),
- B(TestEqualStrict), R(9),
+ B(TestEqualStrict), R(9), U8(0),
B(JumpIfTrue), U8(4),
B(Jump), U8(5),
B(Ldar), R(10),
@@ -137,9 +137,9 @@ constant pool: [
InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
]
handlers: [
- [7, 114, 120],
+ [7, 115, 121],
[10, 80, 82],
- [192, 202, 204],
+ [198, 208, 210],
]
---
@@ -149,7 +149,7 @@ snippet: "
"
frame size: 16
parameter count: 1
-bytecode array length: 279
+bytecode array length: 287
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaConstant), U8(0),
@@ -180,15 +180,15 @@ bytecodes: [
/* 73 S> */ B(LdaZero),
B(Star), R(10),
B(Mov), R(1), R(11),
- B(Jump), U8(48),
- B(Jump), U8(34),
+ B(Jump), U8(49),
+ B(Jump), U8(35),
B(Star), R(14),
B(Ldar), R(closure),
B(CreateCatchContext), R(14), U8(5),
B(Star), R(13),
B(PushContext), R(9),
B(LdaSmi), U8(2),
- B(TestEqualStrict), R(5),
+ B(TestEqualStrict), R(5), U8(13),
B(JumpIfFalse), U8(6),
B(LdaSmi), U8(1),
B(Star), R(5),
@@ -204,24 +204,24 @@ bytecodes: [
B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), R(0), U8(0),
B(Star), R(12),
B(LdaZero),
- B(TestEqualStrict), R(5),
- B(JumpIfTrue), U8(116),
+ B(TestEqualStrict), R(5), U8(14),
+ B(JumpIfTrue), U8(120),
B(LdaUndefined),
- B(TestEqualStrict), R(3),
- B(JumpIfTrue), U8(111),
- B(LdrNamedProperty), R(3), U8(6), U8(13), R(7),
+ B(TestEqualStrict), R(3), U8(15),
+ B(JumpIfTrue), U8(114),
+ B(LdrNamedProperty), R(3), U8(6), U8(16), R(7),
B(LdaNull),
- B(TestEqual), R(7),
+ B(TestEqual), R(7), U8(18),
B(JumpIfFalse), U8(4),
- B(Jump), U8(99),
+ B(Jump), U8(101),
B(LdaSmi), U8(1),
- B(TestEqualStrict), R(5),
- B(JumpIfFalse), U8(68),
+ B(TestEqualStrict), R(5), U8(19),
+ B(JumpIfFalse), U8(69),
B(Ldar), R(7),
B(TypeOf),
B(Star), R(13),
B(LdaConstant), U8(7),
- B(TestEqualStrict), R(13),
+ B(TestEqualStrict), R(13), U8(20),
B(JumpIfFalse), U8(4),
B(Jump), U8(18),
B(Wide), B(LdaSmi), U16(129),
@@ -254,10 +254,10 @@ bytecodes: [
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(8), U8(1),
B(CallRuntime), U16(Runtime::kInterpreterSetPendingMessage), R(12), U8(1),
B(LdaZero),
- B(TestEqualStrict), R(10),
- B(JumpIfTrue), U8(10),
+ B(TestEqualStrict), R(10), U8(0),
+ B(JumpIfTrue), U8(11),
B(LdaSmi), U8(1),
- B(TestEqualStrict), R(10),
+ B(TestEqualStrict), R(10), U8(0),
B(JumpIfTrue), U8(7),
B(Jump), U8(8),
B(Ldar), R(11),
@@ -279,9 +279,9 @@ constant pool: [
InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
]
handlers: [
- [11, 115, 121],
+ [11, 116, 122],
[14, 81, 83],
- [194, 204, 206],
+ [200, 210, 212],
]
---
@@ -293,7 +293,7 @@ snippet: "
"
frame size: 15
parameter count: 1
-bytecode array length: 284
+bytecode array length: 293
bytecodes: [
/* 30 E> */ B(StackCheck),
B(LdaZero),
@@ -314,7 +314,7 @@ bytecodes: [
B(JumpIfFalse), U8(7),
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(3), U8(1),
B(LdaNamedProperty), R(3), U8(3), U8(9),
- B(JumpIfToBooleanTrue), U8(39),
+ B(JumpIfToBooleanTrue), U8(41),
B(LdrNamedProperty), R(3), U8(4), U8(11), R(5),
B(LdaSmi), U8(2),
B(Star), R(4),
@@ -322,24 +322,24 @@ bytecodes: [
/* 34 E> */ B(StackCheck),
B(Mov), R(0), R(1),
/* 66 S> */ B(LdaSmi), U8(10),
- /* 72 E> */ B(TestEqual), R(1),
+ /* 72 E> */ B(TestEqual), R(1), U8(13),
B(JumpIfFalse), U8(4),
- /* 79 S> */ B(Jump), U8(13),
+ /* 79 S> */ B(Jump), U8(14),
/* 91 S> */ B(LdaSmi), U8(20),
- /* 97 E> */ B(TestEqual), R(1),
+ /* 97 E> */ B(TestEqual), R(1), U8(14),
B(JumpIfFalse), U8(4),
/* 104 S> */ B(Jump), U8(7),
B(LdaZero),
B(Star), R(4),
- B(Jump), U8(-65),
- B(Jump), U8(34),
+ B(Jump), U8(-67),
+ B(Jump), U8(35),
B(Star), R(13),
B(Ldar), R(closure),
B(CreateCatchContext), R(13), U8(5),
B(Star), R(12),
B(PushContext), R(8),
B(LdaSmi), U8(2),
- B(TestEqualStrict), R(4),
+ B(TestEqualStrict), R(4), U8(15),
B(JumpIfFalse), U8(6),
B(LdaSmi), U8(1),
B(Star), R(4),
@@ -355,24 +355,24 @@ bytecodes: [
B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), R(0), U8(0),
B(Star), R(11),
B(LdaZero),
- B(TestEqualStrict), R(4),
- B(JumpIfTrue), U8(116),
+ B(TestEqualStrict), R(4), U8(16),
+ B(JumpIfTrue), U8(120),
B(LdaUndefined),
- B(TestEqualStrict), R(2),
- B(JumpIfTrue), U8(111),
- B(LdrNamedProperty), R(2), U8(6), U8(13), R(6),
+ B(TestEqualStrict), R(2), U8(17),
+ B(JumpIfTrue), U8(114),
+ B(LdrNamedProperty), R(2), U8(6), U8(18), R(6),
B(LdaNull),
- B(TestEqual), R(6),
+ B(TestEqual), R(6), U8(20),
B(JumpIfFalse), U8(4),
- B(Jump), U8(99),
+ B(Jump), U8(101),
B(LdaSmi), U8(1),
- B(TestEqualStrict), R(4),
- B(JumpIfFalse), U8(68),
+ B(TestEqualStrict), R(4), U8(21),
+ B(JumpIfFalse), U8(69),
B(Ldar), R(6),
B(TypeOf),
B(Star), R(12),
B(LdaConstant), U8(7),
- B(TestEqualStrict), R(12),
+ B(TestEqualStrict), R(12), U8(22),
B(JumpIfFalse), U8(4),
B(Jump), U8(18),
B(Wide), B(LdaSmi), U16(129),
@@ -405,7 +405,7 @@ bytecodes: [
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(7), U8(1),
B(CallRuntime), U16(Runtime::kInterpreterSetPendingMessage), R(11), U8(1),
B(LdaZero),
- B(TestEqualStrict), R(9),
+ B(TestEqualStrict), R(9), U8(0),
B(JumpIfTrue), U8(4),
B(Jump), U8(5),
B(Ldar), R(10),
@@ -425,9 +425,9 @@ constant pool: [
InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
]
handlers: [
- [7, 130, 136],
- [10, 96, 98],
- [208, 218, 220],
+ [7, 133, 139],
+ [10, 98, 100],
+ [216, 226, 228],
]
---
@@ -437,7 +437,7 @@ snippet: "
"
frame size: 14
parameter count: 1
-bytecode array length: 292
+bytecode array length: 300
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(CreateObjectLiteral), U8(0), U8(0), U8(1), R(8),
@@ -471,15 +471,15 @@ bytecodes: [
/* 96 E> */ B(LdrNamedProperty), R(0), U8(6), U8(15), R(9),
B(LdaZero),
B(Star), R(8),
- B(Jump), U8(48),
- B(Jump), U8(34),
+ B(Jump), U8(49),
+ B(Jump), U8(35),
B(Star), R(12),
B(Ldar), R(closure),
B(CreateCatchContext), R(12), U8(7),
B(Star), R(11),
B(PushContext), R(7),
B(LdaSmi), U8(2),
- B(TestEqualStrict), R(3),
+ B(TestEqualStrict), R(3), U8(17),
B(JumpIfFalse), U8(6),
B(LdaSmi), U8(1),
B(Star), R(3),
@@ -495,24 +495,24 @@ bytecodes: [
B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), R(0), U8(0),
B(Star), R(10),
B(LdaZero),
- B(TestEqualStrict), R(3),
- B(JumpIfTrue), U8(116),
+ B(TestEqualStrict), R(3), U8(18),
+ B(JumpIfTrue), U8(120),
B(LdaUndefined),
- B(TestEqualStrict), R(1),
- B(JumpIfTrue), U8(111),
- B(LdrNamedProperty), R(1), U8(8), U8(17), R(5),
+ B(TestEqualStrict), R(1), U8(19),
+ B(JumpIfTrue), U8(114),
+ B(LdrNamedProperty), R(1), U8(8), U8(20), R(5),
B(LdaNull),
- B(TestEqual), R(5),
+ B(TestEqual), R(5), U8(22),
B(JumpIfFalse), U8(4),
- B(Jump), U8(99),
+ B(Jump), U8(101),
B(LdaSmi), U8(1),
- B(TestEqualStrict), R(3),
- B(JumpIfFalse), U8(68),
+ B(TestEqualStrict), R(3), U8(23),
+ B(JumpIfFalse), U8(69),
B(Ldar), R(5),
B(TypeOf),
B(Star), R(11),
B(LdaConstant), U8(9),
- B(TestEqualStrict), R(11),
+ B(TestEqualStrict), R(11), U8(24),
B(JumpIfFalse), U8(4),
B(Jump), U8(18),
B(Wide), B(LdaSmi), U16(129),
@@ -545,10 +545,10 @@ bytecodes: [
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(6), U8(1),
B(CallRuntime), U16(Runtime::kInterpreterSetPendingMessage), R(10), U8(1),
B(LdaZero),
- B(TestEqualStrict), R(8),
- B(JumpIfTrue), U8(10),
+ B(TestEqualStrict), R(8), U8(0),
+ B(JumpIfTrue), U8(11),
B(LdaSmi), U8(1),
- B(TestEqualStrict), R(8),
+ B(TestEqualStrict), R(8), U8(0),
B(JumpIfTrue), U8(7),
B(Jump), U8(8),
B(Ldar), R(9),
@@ -572,8 +572,8 @@ constant pool: [
InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
]
handlers: [
- [15, 128, 134],
+ [15, 129, 135],
[18, 94, 96],
- [207, 217, 219],
+ [213, 223, 225],
]
« src/globals.h ('K') | « test/cctest/interpreter/bytecode_expectations/ForIn.golden ('k') | test/cctest/interpreter/bytecode_expectations/Generators.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698