Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2286233002: Replaced PassRefPtr copies with moves in Source/core/animation. (Closed)

Created:
4 years, 3 months ago by Bugs Nash
Modified:
4 years, 3 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replaced PassRefPtr copies with moves in Source/core/animation. Part of making PassRefPtr move only, in preparation for the removal of PassRefPtr. BUG=640449 Committed: https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3 Cr-Commit-Position: refs/heads/master@{#415077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -42 lines) Patch
M third_party/WebKit/Source/core/animation/BasicShapePropertyFunctions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CustomCompositorAnimations.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/FilterInterpolationFunctions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolableValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolationEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectModel.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/LegacyStyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/PrimitiveInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/ShadowListPropertyFunctions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/TypedInterpolationValue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBox.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBoxAndBool.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLengthPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLengthPoint3D.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableLengthSize.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatablePath.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableSVGPaint.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableShadow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableStrokeDasharrayList.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
Bugs Nash
4 years, 3 months ago (2016-08-29 04:57:41 UTC) #4
alancutter (OOO until 2018)
Is it really so few for core/animation? LGTM.
4 years, 3 months ago (2016-08-29 05:15:38 UTC) #6
Yuta Kitamura
lgtm
4 years, 3 months ago (2016-08-29 05:18:07 UTC) #7
Bugs Nash
On 2016/08/29 at 05:15:38, alancutter wrote: > Is it really so few for core/animation? > ...
4 years, 3 months ago (2016-08-29 05:26:24 UTC) #8
Bugs Nash
4 years, 3 months ago (2016-08-29 05:26:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2286233002/1
4 years, 3 months ago (2016-08-29 23:29:02 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 04:11:23 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 04:13:57 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81fd4d944c6a8920f58af346722499425ed4a7b3
Cr-Commit-Position: refs/heads/master@{#415077}

Powered by Google App Engine
This is Rietveld 408576698