third_party/WebKit/Source/core/animation/TypedInterpolationValue.h - Issue 2286233002: Replaced PassRefPtr copies with moves in Source/core/animation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/TypedInterpolationValue.h

Issue 2286233002: Replaced PassRefPtr copies with moves in Source/core/animation. (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/StringKeyframe.cpp ('k') | third_party/WebKit/Source/core/animation/animatable/AnimatableLengthBox.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/TypedInterpolationValue.h

diff --git a/third_party/WebKit/Source/core/animation/TypedInterpolationValue.h b/third_party/WebKit/Source/core/animation/TypedInterpolationValue.h

index d5b7a3c38126693bf5667f536fdd12d2d7e27958..b4958839ded8d9d79bfd99011d26eaec6ad4f8ef 100644

--- a/third_party/WebKit/Source/core/animation/TypedInterpolationValue.h

+++ b/third_party/WebKit/Source/core/animation/TypedInterpolationValue.h

@@ -18,7 +18,7 @@ class TypedInterpolationValue {

public:

static std::unique_ptr<TypedInterpolationValue> create(const InterpolationType& type, std::unique_ptr<InterpolableValue> interpolableValue, PassRefPtr<NonInterpolableValue> nonInterpolableValue = nullptr)

{

- return wrapUnique(new TypedInterpolationValue(type, std::move(interpolableValue), nonInterpolableValue));

+ return wrapUnique(new TypedInterpolationValue(type, std::move(interpolableValue), std::move(nonInterpolableValue)));

}

std::unique_ptr<TypedInterpolationValue> clone() const

@@ -37,7 +37,7 @@ public:

private:

TypedInterpolationValue(const InterpolationType& type, std::unique_ptr<InterpolableValue> interpolableValue, PassRefPtr<NonInterpolableValue> nonInterpolableValue)

: m_type(type)

- , m_value(std::move(interpolableValue), nonInterpolableValue)

+ , m_value(std::move(interpolableValue), std::move(nonInterpolableValue))

{

DCHECK(m_value.interpolableValue);

}