third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h - Issue 2286233002: Replaced PassRefPtr copies with moves in Source/core/animation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h

Issue 2286233002: Replaced PassRefPtr copies with moves in Source/core/animation. (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/animatable/AnimatableStrokeDasharrayList.h ('k') | third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h

diff --git a/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h b/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h

index bb3f5ea9506ae4a34be55e72effc1eb31a90c660..da23b9d81f0fe169caef966af78176b6c04718e3 100644

--- a/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h

+++ b/third_party/WebKit/Source/core/animation/animatable/AnimatableValueKeyframe.h

@@ -34,7 +34,7 @@ public:

public:

static PassRefPtr<PropertySpecificKeyframe> create(double offset, PassRefPtr<TimingFunction> easing, PassRefPtr<AnimatableValue> value, EffectModel::CompositeOperation composite)

{

- return adoptRef(new PropertySpecificKeyframe(offset, easing, value, composite));

+ return adoptRef(new PropertySpecificKeyframe(offset, std::move(easing), std::move(value), composite));

}

AnimatableValue* value() const { return m_value.get(); }

@@ -45,7 +45,7 @@ public:

private:

PropertySpecificKeyframe(double offset, PassRefPtr<TimingFunction> easing, PassRefPtr<AnimatableValue> value, EffectModel::CompositeOperation composite)

- : Keyframe::PropertySpecificKeyframe(offset, easing, composite)

+ : Keyframe::PropertySpecificKeyframe(offset, std::move(easing), composite)

, m_value(value)

{ }