third_party/WebKit/Source/core/animation/CustomCompositorAnimations.cpp - Issue 2286233002: Replaced PassRefPtr copies with moves in Source/core/animation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CustomCompositorAnimations.cpp

Issue 2286233002: Replaced PassRefPtr copies with moves in Source/core/animation. (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/FilterInterpolationFunctions.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CustomCompositorAnimations.cpp

diff --git a/third_party/WebKit/Source/core/animation/CustomCompositorAnimations.cpp b/third_party/WebKit/Source/core/animation/CustomCompositorAnimations.cpp

index 13f7f2e4c8957312feba343e79f59c66b9f1f1b5..04fa244c8ab8b5dc67ad1e8931fa215a02122cf2 100644

--- a/third_party/WebKit/Source/core/animation/CustomCompositorAnimations.cpp

+++ b/third_party/WebKit/Source/core/animation/CustomCompositorAnimations.cpp

@@ -59,10 +59,10 @@ static KeyframeEffect* updateInfiniteKeyframeEffect(const KeyframeEffect& keyfra

static Animation* createOrUpdateAnimation(Animation* animation, Element& element, CSSPropertyID propertyId, PassRefPtr<AnimatableValue> newValue)

{

if (!animation) {

- KeyframeEffect* keyframeEffect = createInfiniteKeyFrameEffect(element, propertyId, newValue);

+ KeyframeEffect* keyframeEffect = createInfiniteKeyFrameEffect(element, propertyId, std::move(newValue));

return element.document().timeline().play(keyframeEffect);

}

- KeyframeEffect* keyframeEffect = updateInfiniteKeyframeEffect(*toKeyframeEffect(animation->effect()), propertyId, newValue);

+ KeyframeEffect* keyframeEffect = updateInfiniteKeyframeEffect(*toKeyframeEffect(animation->effect()), propertyId, std::move(newValue));

animation->setEffect(keyframeEffect);

return animation;

}