Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5327)

Unified Diff: chrome/test/chromedriver/commands_unittest.cc

Issue 2285933003: Remove more usage of the base::ListValue::Append(Value*) overload. (Closed)
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/web_view_impl.cc ('k') | chrome/test/chromedriver/element_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/commands_unittest.cc
diff --git a/chrome/test/chromedriver/commands_unittest.cc b/chrome/test/chromedriver/commands_unittest.cc
index 5e678f8844a7be5454225284226c800dd5e99a84..b8d69c936744e46e82d1349128495883a7062483 100644
--- a/chrome/test/chromedriver/commands_unittest.cc
+++ b/chrome/test/chromedriver/commands_unittest.cc
@@ -363,9 +363,9 @@ class FindElementWebView : public StubWebView {
base::DictionaryValue element2;
element2.SetString("ELEMENT", "2");
base::ListValue list;
- list.Append(element1.DeepCopy());
- list.Append(element2.DeepCopy());
- result_.reset(list.DeepCopy());
+ list.Append(element1.CreateDeepCopy());
+ list.Append(element2.CreateDeepCopy());
+ result_ = list.CreateDeepCopy();
}
break;
}
@@ -460,7 +460,7 @@ TEST(CommandsTest, SuccessfulFindElement) {
base::DictionaryValue param;
param.SetString("id", "a");
base::ListValue expected_args;
- expected_args.Append(param.DeepCopy());
+ expected_args.Append(param.CreateDeepCopy());
web_view.Verify("frame_id1", &expected_args, result.get());
}
@@ -491,7 +491,7 @@ TEST(CommandsTest, SuccessfulFindElements) {
base::DictionaryValue param;
param.SetString("name", "b");
base::ListValue expected_args;
- expected_args.Append(param.DeepCopy());
+ expected_args.Append(param.CreateDeepCopy());
web_view.Verify("frame_id2", &expected_args, result.get());
}
@@ -529,8 +529,8 @@ TEST(CommandsTest, SuccessfulFindChildElement) {
base::DictionaryValue root_element_param;
root_element_param.SetString("ELEMENT", element_id);
base::ListValue expected_args;
- expected_args.Append(locator_param.DeepCopy());
- expected_args.Append(root_element_param.DeepCopy());
+ expected_args.Append(locator_param.CreateDeepCopy());
+ expected_args.Append(root_element_param.CreateDeepCopy());
web_view.Verify("frame_id3", &expected_args, result.get());
}
@@ -567,8 +567,8 @@ TEST(CommandsTest, SuccessfulFindChildElements) {
base::DictionaryValue root_element_param;
root_element_param.SetString("ELEMENT", element_id);
base::ListValue expected_args;
- expected_args.Append(locator_param.DeepCopy());
- expected_args.Append(root_element_param.DeepCopy());
+ expected_args.Append(locator_param.CreateDeepCopy());
+ expected_args.Append(root_element_param.CreateDeepCopy());
web_view.Verify("frame_id4", &expected_args, result.get());
}
« no previous file with comments | « chrome/test/chromedriver/chrome/web_view_impl.cc ('k') | chrome/test/chromedriver/element_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698