chrome/test/chromedriver/element_commands.cc - Issue 2285933003: Remove more usage of the base::ListValue::Append(Value*) overload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/element_commands.cc

Issue 2285933003: Remove more usage of the base::ListValue::Append(Value*) overload. (Closed)

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/element_commands.cc

diff --git a/chrome/test/chromedriver/element_commands.cc b/chrome/test/chromedriver/element_commands.cc

index a39b7333517e1704f0739aa7444323f82bd5bedb..124bb4e3c770619ce4e9368e53ffff64c183fc76 100644

--- a/chrome/test/chromedriver/element_commands.cc

+++ b/chrome/test/chromedriver/element_commands.cc

@@ -473,7 +473,7 @@ Status ExecuteGetElementLocationOnceScrolledIntoView(

session, web_view, element_id, &offset, &location);

if (status.IsError())

return status;

- value->reset(CreateValueFrom(location));

+ *value = CreateValueFrom(location);

return Status(kOk);

}