Remove more usage of the base::ListValue::Append(Value*) overload.

chrome/test/chromedriver/commands_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/commands.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
@@ skipping 345 matching lines @@
         if (only_one_) {
           base::DictionaryValue element;
           element.SetString("ELEMENT", "1");
           result_.reset(element.DeepCopy());
         } else {
           base::DictionaryValue element1;
           element1.SetString("ELEMENT", "1");
           base::DictionaryValue element2;
           element2.SetString("ELEMENT", "2");
           base::ListValue list;
-          list.Append(element1.DeepCopy());
-          list.Append(element2.DeepCopy());
-          result_.reset(list.DeepCopy());
+          list.Append(element1.CreateDeepCopy());
+          list.Append(element2.CreateDeepCopy());
+          result_ = list.CreateDeepCopy();
         }
         break;
       }
       case kElementNotExistsQueryOnce: {
         if (only_one_)
           result_ = base::Value::CreateNullValue();
         else
           result_.reset(new base::ListValue());
         break;
       }
@@ skipping 74 matching lines @@
   base::DictionaryValue params;
   params.SetString("using", "id");
   params.SetString("value", "a");
   std::unique_ptr<base::Value> result;
   ASSERT_EQ(kOk,
             ExecuteFindElement(1, &session, &web_view, params, &result,
                                nullptr).code());
   base::DictionaryValue param;
   param.SetString("id", "a");
   base::ListValue expected_args;
-  expected_args.Append(param.DeepCopy());
+  expected_args.Append(param.CreateDeepCopy());
   web_view.Verify("frame_id1", &expected_args, result.get());
 }
 
 TEST(CommandsTest, FailedFindElement) {
   FindElementWebView web_view(true, kElementNotExistsQueryOnce);
   Session session("id");
   base::DictionaryValue params;
   params.SetString("using", "id");
   params.SetString("value", "a");
   std::unique_ptr<base::Value> result;
@@ skipping 10 matching lines @@
   base::DictionaryValue params;
   params.SetString("using", "name");
   params.SetString("value", "b");
   std::unique_ptr<base::Value> result;
   ASSERT_EQ(kOk,
             ExecuteFindElements(1, &session, &web_view, params, &result,
                                 nullptr).code());
   base::DictionaryValue param;
   param.SetString("name", "b");
   base::ListValue expected_args;
-  expected_args.Append(param.DeepCopy());
+  expected_args.Append(param.CreateDeepCopy());
   web_view.Verify("frame_id2", &expected_args, result.get());
 }
 
 TEST(CommandsTest, FailedFindElements) {
   Session session("id");
   FindElementWebView web_view(false, kElementNotExistsQueryOnce);
   base::DictionaryValue params;
   params.SetString("using", "id");
   params.SetString("value", "a");
   std::unique_ptr<base::Value> result;
@@ skipping 17 matching lines @@
   std::unique_ptr<base::Value> result;
   ASSERT_EQ(
       kOk,
       ExecuteFindChildElement(
           1, &session, &web_view, element_id, params, &result).code());
   base::DictionaryValue locator_param;
   locator_param.SetString("tag name", "div");
   base::DictionaryValue root_element_param;
   root_element_param.SetString("ELEMENT", element_id);
   base::ListValue expected_args;
-  expected_args.Append(locator_param.DeepCopy());
-  expected_args.Append(root_element_param.DeepCopy());
+  expected_args.Append(locator_param.CreateDeepCopy());
+  expected_args.Append(root_element_param.CreateDeepCopy());
   web_view.Verify("frame_id3", &expected_args, result.get());
 }
 
 TEST(CommandsTest, FailedFindChildElement) {
   Session session("id");
   FindElementWebView web_view(true, kElementNotExistsQueryOnce);
   base::DictionaryValue params;
   params.SetString("using", "id");
   params.SetString("value", "a");
   std::string element_id = "1";
@@ skipping 16 matching lines @@
   std::unique_ptr<base::Value> result;
   ASSERT_EQ(
       kOk,
       ExecuteFindChildElements(
           1, &session, &web_view, element_id, params, &result).code());
   base::DictionaryValue locator_param;
   locator_param.SetString("class name", "c");
   base::DictionaryValue root_element_param;
   root_element_param.SetString("ELEMENT", element_id);
   base::ListValue expected_args;
-  expected_args.Append(locator_param.DeepCopy());
-  expected_args.Append(root_element_param.DeepCopy());
+  expected_args.Append(locator_param.CreateDeepCopy());
+  expected_args.Append(root_element_param.CreateDeepCopy());
   web_view.Verify("frame_id4", &expected_args, result.get());
 }
 
 TEST(CommandsTest, FailedFindChildElements) {
   Session session("id");
   FindElementWebView web_view(false, kElementNotExistsQueryOnce);
   base::DictionaryValue params;
   params.SetString("using", "id");
   params.SetString("value", "a");
   std::string element_id = "1";
@@ skipping 246 matching lines @@
       cmd,
       false,
       params,
       id,
       base::Bind(&OnFailBecauseErrorNotifyingListeners, &run_loop));
   run_loop.Run();
 
   thread->task_runner()->PostTask(FROM_HERE,
                                   base::Bind(&VerifySessionWasDeleted));
 }