Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4311)

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl.cc

Issue 2285933003: Remove more usage of the base::ListValue::Append(Value*) overload. (Closed)
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/web_view_impl.cc
diff --git a/chrome/test/chromedriver/chrome/web_view_impl.cc b/chrome/test/chromedriver/chrome/web_view_impl.cc
index 8dc01b002e2b19ee7a5ef7d1c0525e58e5675e16..554f4e21fc96d0aede6992cc1f78166ca5bb7f6a 100644
--- a/chrome/test/chromedriver/chrome/web_view_impl.cc
+++ b/chrome/test/chromedriver/chrome/web_view_impl.cc
@@ -513,7 +513,7 @@ Status WebViewImpl::SetFileInputFiles(
if (status.IsError())
return status;
base::ListValue args;
- args.Append(element.DeepCopy());
+ args.Append(element.CreateDeepCopy());
bool found_node;
int node_id;
status = internal::GetNodeIdFromFunction(
@@ -675,7 +675,7 @@ Status WebViewImpl::CallAsyncFunctionInternal(
std::unique_ptr<base::Value>* result) {
base::ListValue async_args;
async_args.AppendString("return (" + function + ").apply(null, arguments);");
- async_args.Append(args.DeepCopy());
+ async_args.Append(args.CreateDeepCopy());
async_args.AppendBoolean(is_user_supplied);
async_args.AppendInteger(timeout.InMilliseconds());
std::unique_ptr<base::Value> tmp;
« no previous file with comments | « chrome/test/chromedriver/chrome/automation_extension.cc ('k') | chrome/test/chromedriver/commands_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698