Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2284283002: Remove stl_util's STLElementDeleter from sync. (Closed)

Created:
1 year, 2 months ago by Avi (ping after 24h)
Modified:
1 year, 2 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stl_util's STLElementDeleter from sync. BUG=555865 Committed: https://crrev.com/fb72670f2ba117297818ac424b28b4adde3012a8 Cr-Commit-Position: refs/heads/master@{#415147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -64 lines) Patch
M components/browser_sync/browser/profile_sync_service.cc View 4 chunks +9 lines, -12 lines 0 comments Download
M components/sync/core/sync_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/core/test/fake_sync_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync/core_impl/protocol_event_buffer.h View 2 chunks +5 lines, -5 lines 0 comments Download
M components/sync/core_impl/protocol_event_buffer.cc View 1 chunk +9 lines, -13 lines 0 comments Download
M components/sync/core_impl/protocol_event_buffer_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M components/sync/core_impl/sync_manager_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync/core_impl/sync_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/core_impl/test/fake_sync_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_host_core.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_host_core.cc View 5 chunks +12 lines, -14 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl.h View 2 chunks +4 lines, -2 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_mock.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_host_mock.cc View 1 chunk +2 lines, -1 line 0 comments Download
Trybot results:  linux_chromium_chromeos_rel_ng   win_chromium_compile_dbg_ng   win_chromium_x64_rel_ng   win_chromium_rel_ng   win_chromium_compile_dbg_ng   win_clang   ios-device   mac_chromium_compile_dbg_ng   mac_chromium_rel_ng   ios-simulator   cast_shell_android   android_clang_dbg_recipe   android_arm64_dbg_recipe   linux_chromium_asan_rel_ng   linux_chromium_chromeos_compile_dbg_ng   android_compile_dbg   linux_chromium_rel_ng   linux_chromium_compile_dbg_ng   chromeos_x86-generic_chromium_compile_only_ng   cast_shell_linux   chromeos_amd64-generic_chromium_compile_only_ng   linux_chromium_chromeos_rel_ng   linux_chromium_chromeos_ozone_rel_ng   chromeos_daisy_chromium_compile_only_ng   linux_chromium_clobber_rel_ng   chromium_presubmit   linux_android_rel_ng   chromium_presubmit   linux_android_rel_ng   chromium_presubmit   linux_android_rel_ng   chromium_presubmit   linux_android_rel_ng   chromium_presubmit   linux_android_rel_ng   chromium_presubmit   win_chromium_x64_rel_ng   linux_android_rel_ng   linux_android_rel_ng   chromium_presubmit   win_chromium_x64_rel_ng   linux_android_rel_ng   win_clang   win_chromium_compile_dbg_ng   win_chromium_x64_rel_ng   win_chromium_rel_ng   mac_chromium_compile_dbg_ng   ios-device   ios-simulator   mac_chromium_rel_ng   linux_chromium_asan_rel_ng   linux_chromium_chromeos_compile_dbg_ng   linux_chromium_rel_ng   chromeos_x86-generic_chromium_compile_only_ng   chromium_presubmit   linux_chromium_compile_dbg_ng   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_linux   chromeos_daisy_chromium_compile_only_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_clobber_rel_ng   linux_android_rel_ng   android_clang_dbg_recipe   android_arm64_dbg_recipe   cast_shell_android   android_compile_dbg 

Messages

Total messages: 27 (22 generated)
Avi (ping after 24h)
1 year, 2 months ago (2016-08-29 15:01:52 UTC) #18
Nicolas Zea
This is awesome, thanks Avi! LGTM
1 year, 2 months ago (2016-08-29 18:43:15 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284283002/1
1 year, 2 months ago (2016-08-29 19:50:58 UTC) #24
commit-bot: I haz the power
Committed patchset #1 (id:1)
1 year, 2 months ago (2016-08-30 05:19:58 UTC) #25
commit-bot: I haz the power
1 year, 2 months ago (2016-08-30 05:22:22 UTC) #27
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb72670f2ba117297818ac424b28b4adde3012a8
Cr-Commit-Position: refs/heads/master@{#415147}

Powered by Google App Engine
This is Rietveld efc10ee0f