Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: components/sync/core_impl/protocol_event_buffer_unittest.cc

Issue 2284283002: Remove stl_util's STLElementDeleter from sync. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/core_impl/protocol_event_buffer.cc ('k') | components/sync/core_impl/sync_manager_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/core_impl/protocol_event_buffer_unittest.cc
diff --git a/components/sync/core_impl/protocol_event_buffer_unittest.cc b/components/sync/core_impl/protocol_event_buffer_unittest.cc
index 0f187198e6410ad109f1485b51fc567084a67efd..88591e2917e7e0fe5da2ba153d7e727fd660abc8 100644
--- a/components/sync/core_impl/protocol_event_buffer_unittest.cc
+++ b/components/sync/core_impl/protocol_event_buffer_unittest.cc
@@ -9,7 +9,6 @@
#include <memory>
-#include "base/memory/scoped_vector.h"
#include "base/time/time.h"
#include "components/sync/engine/events/poll_get_updates_request_event.h"
#include "components/sync/engine/events/protocol_event.h"
@@ -52,7 +51,7 @@ TEST_F(ProtocolEventBufferTest, AddThenReturnEvents) {
buffer_.RecordProtocolEvent(*e1);
buffer_.RecordProtocolEvent(*e2);
- ScopedVector<ProtocolEvent> buffered_events(
+ std::vector<std::unique_ptr<ProtocolEvent>> buffered_events(
buffer_.GetBufferedProtocolEvents());
ASSERT_EQ(2U, buffered_events.size());
@@ -66,7 +65,7 @@ TEST_F(ProtocolEventBufferTest, AddThenOverflowThenReturnEvents) {
buffer_.RecordProtocolEvent(*e);
}
- ScopedVector<ProtocolEvent> buffered_events(
+ std::vector<std::unique_ptr<ProtocolEvent>> buffered_events(
buffer_.GetBufferedProtocolEvents());
ASSERT_EQ(ProtocolEventBuffer::kBufferSize, buffered_events.size());
« no previous file with comments | « components/sync/core_impl/protocol_event_buffer.cc ('k') | components/sync/core_impl/sync_manager_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698