Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: components/sync/core_impl/protocol_event_buffer.h

Issue 2284283002: Remove stl_util's STLElementDeleter from sync. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SYNC_CORE_IMPL_PROTOCOL_EVENT_BUFFER_H_ 5 #ifndef COMPONENTS_SYNC_CORE_IMPL_PROTOCOL_EVENT_BUFFER_H_
6 #define COMPONENTS_SYNC_CORE_IMPL_PROTOCOL_EVENT_BUFFER_H_ 6 #define COMPONENTS_SYNC_CORE_IMPL_PROTOCOL_EVENT_BUFFER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <deque> 10 #include <deque>
11 #include <memory>
12 #include <vector>
11 13
12 #include "base/macros.h" 14 #include "base/macros.h"
13 #include "base/memory/scoped_vector.h"
14 15
15 namespace syncer { 16 namespace syncer {
16 17
17 class ProtocolEvent; 18 class ProtocolEvent;
18 19
19 // A container for ProtocolEvents. 20 // A container for ProtocolEvents.
20 // 21 //
21 // Stores at most kBufferSize events, then starts dropping the oldest events. 22 // Stores at most kBufferSize events, then starts dropping the oldest events.
22 class ProtocolEventBuffer { 23 class ProtocolEventBuffer {
23 public: 24 public:
24 static const size_t kBufferSize; 25 static const size_t kBufferSize;
25 26
26 ProtocolEventBuffer(); 27 ProtocolEventBuffer();
27 ~ProtocolEventBuffer(); 28 ~ProtocolEventBuffer();
28 29
29 // Records an event. May cause the oldest event to be dropped. 30 // Records an event. May cause the oldest event to be dropped.
30 void RecordProtocolEvent(const ProtocolEvent& event); 31 void RecordProtocolEvent(const ProtocolEvent& event);
31 32
32 // Returns the buffered contents. Will not clear the buffer. 33 // Returns copies of the buffered contents. Will not clear the buffer.
33 ScopedVector<ProtocolEvent> GetBufferedProtocolEvents() const; 34 std::vector<std::unique_ptr<ProtocolEvent>> GetBufferedProtocolEvents() const;
34 35
35 private: 36 private:
36 std::deque<ProtocolEvent*> buffer_; 37 std::deque<std::unique_ptr<ProtocolEvent>> buffer_;
37 base::STLElementDeleter<std::deque<ProtocolEvent*>> buffer_deleter_;
38 38
39 DISALLOW_COPY_AND_ASSIGN(ProtocolEventBuffer); 39 DISALLOW_COPY_AND_ASSIGN(ProtocolEventBuffer);
40 }; 40 };
41 41
42 } // namespace syncer 42 } // namespace syncer
43 43
44 #endif // COMPONENTS_SYNC_CORE_IMPL_PROTOCOL_EVENT_BUFFER_H_ 44 #endif // COMPONENTS_SYNC_CORE_IMPL_PROTOCOL_EVENT_BUFFER_H_
OLDNEW
« no previous file with comments | « components/sync/core/test/fake_sync_manager.h ('k') | components/sync/core_impl/protocol_event_buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698