Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 228343002: Cleanup webRequest/Internal API and permission registration. (Closed)

Created:
6 years, 8 months ago by pneubeck (no reviews)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, vabr (Chromium)
Visibility:
Public.

Description

Cleanup webRequest/Internal API and permission registration. The webRequestInternal permission was unused, thus: - Remove the permission webRequestInternal. While there, also does: - Remove manual registration of webRequest API and instead rely on automatically generated registration. - Remove context 'content_script' from webRequestInternal API. BUG=359964 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262958

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -33 lines) Patch
M chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.h View 1 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/web_request_internal.json View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/common/extensions_api_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/extension_api.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/common/permissions/api_permission.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/permissions/permission_set.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
pneubeck (no reviews)
ptal It seems that fileBrowserHandlerInternal and downloadsInternal can be cleanup in the same way and ...
6 years, 8 months ago (2014-04-08 09:01:23 UTC) #1
pneubeck (no reviews)
@vabr: FYI
6 years, 8 months ago (2014-04-08 09:26:55 UTC) #2
not at google - send to devlin
Awesome cleanup, thank you. There are another couple of things you can do to clean ...
6 years, 8 months ago (2014-04-08 15:09:36 UTC) #3
Fady Samuel
This won't break <webview>, will it? Could you please run the browser_tests WebViewTest.*? Thanks.
6 years, 8 months ago (2014-04-08 15:18:56 UTC) #4
not at google - send to devlin
On 2014/04/08 15:18:56, Fady Samuel wrote: > This won't break <webview>, will it? Could you ...
6 years, 8 months ago (2014-04-08 15:44:40 UTC) #5
Fady Samuel
lgtm then
6 years, 8 months ago (2014-04-08 22:22:24 UTC) #6
pneubeck (no reviews)
https://codereview.chromium.org/228343002/diff/1/chrome/common/extensions/api/web_request_internal.json File chrome/common/extensions/api/web_request_internal.json (right): https://codereview.chromium.org/228343002/diff/1/chrome/common/extensions/api/web_request_internal.json#newcode15 chrome/common/extensions/api/web_request_internal.json:15: "nocompile": true, On 2014/04/08 15:09:36, kalman wrote: > You ...
6 years, 8 months ago (2014-04-09 09:08:14 UTC) #7
not at google - send to devlin
lgtm
6 years, 8 months ago (2014-04-09 15:19:36 UTC) #8
pneubeck (no reviews)
On 2014/04/09 15:19:36, kalman wrote: > lgtm If you don't see any problem in doing ...
6 years, 8 months ago (2014-04-09 15:23:11 UTC) #9
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 8 months ago (2014-04-09 15:23:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/228343002/20001
6 years, 8 months ago (2014-04-09 15:23:47 UTC) #11
not at google - send to devlin
lgtm no problem
6 years, 8 months ago (2014-04-09 15:34:20 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 16:12:57 UTC) #13
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=60368
6 years, 8 months ago (2014-04-09 16:12:57 UTC) #14
pneubeck (no reviews)
Jochen, please lgtm chrome/common/extensions_api_resources.grd
6 years, 8 months ago (2014-04-10 06:38:11 UTC) #15
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-10 07:27:59 UTC) #16
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 8 months ago (2014-04-10 07:29:14 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/228343002/20001
6 years, 8 months ago (2014-04-10 07:29:21 UTC) #18
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 13:16:44 UTC) #19
Message was sent while issue was closed. 
Change committed as 262958

Powered by Google App Engine
This is Rietveld 408576698