Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3961)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api.cc

Issue 228343002: Cleanup webRequest/Internal API and permission registration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_request/web_request_api.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_api.cc b/chrome/browser/extensions/api/web_request/web_request_api.cc
index 3ec13f6047fc1f291645a6a1735353eb1c08664b..3e235a2530c5c0bbed0bbc134e68abf2ccdf5a24 100644
--- a/chrome/browser/extensions/api/web_request/web_request_api.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_api.cc
@@ -2149,7 +2149,7 @@ void ClearCacheQuotaHeuristic::OnPageLoad(Bucket* bucket) {
bucket->DeductToken();
}
-bool WebRequestAddEventListener::RunImpl() {
+bool WebRequestInternalAddEventListenerFunction::RunImpl() {
// Argument 0 is the callback, which we don't use here.
ExtensionWebRequestEventRouter::RequestFilter filter;
base::DictionaryValue* value = NULL;
@@ -2229,7 +2229,7 @@ bool WebRequestAddEventListener::RunImpl() {
return true;
}
-void WebRequestEventHandled::RespondWithError(
+void WebRequestInternalEventHandledFunction::RespondWithError(
const std::string& event_name,
const std::string& sub_event_name,
uint64 request_id,
@@ -2245,7 +2245,7 @@ void WebRequestEventHandled::RespondWithError(
response.release());
}
-bool WebRequestEventHandled::RunImpl() {
+bool WebRequestInternalEventHandledFunction::RunImpl() {
std::string event_name;
EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &event_name));

Powered by Google App Engine
This is Rietveld 408576698