Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1369)

Unified Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 228343002: Cleanup webRequest/Internal API and permission registration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/permission_set_unittest.cc
diff --git a/chrome/common/extensions/permissions/permission_set_unittest.cc b/chrome/common/extensions/permissions/permission_set_unittest.cc
index eebf6f392667fc6d2bf5de130d9034ff3beaf696..4bf2c0430edca21939d7ae6cd3cf26d654d870f3 100644
--- a/chrome/common/extensions/permissions/permission_set_unittest.cc
+++ b/chrome/common/extensions/permissions/permission_set_unittest.cc
@@ -743,7 +743,6 @@ TEST(PermissionsTest, PermissionMessages) {
skip.insert(APIPermission::kTerminalPrivate);
skip.insert(APIPermission::kVirtualKeyboardPrivate);
skip.insert(APIPermission::kWallpaperPrivate);
- skip.insert(APIPermission::kWebRequestInternal);
skip.insert(APIPermission::kWebrtcAudioPrivate);
skip.insert(APIPermission::kWebrtcLoggingPrivate);
skip.insert(APIPermission::kWebstorePrivate);
@@ -1467,14 +1466,13 @@ TEST(PermissionsTest, IsEmpty) {
TEST(PermissionsTest, ImpliedPermissions) {
URLPatternSet empty_extent;
APIPermissionSet apis;
- apis.insert(APIPermission::kWebRequest);
apis.insert(APIPermission::kFileBrowserHandler);
- EXPECT_EQ(2U, apis.size());
+ EXPECT_EQ(1U, apis.size());
scoped_refptr<PermissionSet> perm_set;
perm_set = new PermissionSet(apis, ManifestPermissionSet(),
empty_extent, empty_extent);
- EXPECT_EQ(4U, perm_set->apis().size());
+ EXPECT_EQ(2U, perm_set->apis().size());
}
TEST(PermissionsTest, SyncFileSystemPermission) {
« no previous file with comments | « chrome/common/extensions/permissions/chrome_api_permissions.cc ('k') | chrome/common/extensions_api_resources.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698