Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: chrome/common/extensions/permissions/permission_set_unittest.cc

Issue 228343002: Cleanup webRequest/Internal API and permission registration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/json/json_file_value_serializer.h" 6 #include "base/json/json_file_value_serializer.h"
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/common/chrome_paths.h" 10 #include "chrome/common/chrome_paths.h"
(...skipping 725 matching lines...) Expand 10 before | Expand all | Expand 10 after
736 skip.insert(APIPermission::kPrincipalsPrivate); 736 skip.insert(APIPermission::kPrincipalsPrivate);
737 skip.insert(APIPermission::kImageWriterPrivate); 737 skip.insert(APIPermission::kImageWriterPrivate);
738 skip.insert(APIPermission::kReadingListPrivate); 738 skip.insert(APIPermission::kReadingListPrivate);
739 skip.insert(APIPermission::kRtcPrivate); 739 skip.insert(APIPermission::kRtcPrivate);
740 skip.insert(APIPermission::kStreamsPrivate); 740 skip.insert(APIPermission::kStreamsPrivate);
741 skip.insert(APIPermission::kSystemPrivate); 741 skip.insert(APIPermission::kSystemPrivate);
742 skip.insert(APIPermission::kTabCaptureForTab); 742 skip.insert(APIPermission::kTabCaptureForTab);
743 skip.insert(APIPermission::kTerminalPrivate); 743 skip.insert(APIPermission::kTerminalPrivate);
744 skip.insert(APIPermission::kVirtualKeyboardPrivate); 744 skip.insert(APIPermission::kVirtualKeyboardPrivate);
745 skip.insert(APIPermission::kWallpaperPrivate); 745 skip.insert(APIPermission::kWallpaperPrivate);
746 skip.insert(APIPermission::kWebRequestInternal);
747 skip.insert(APIPermission::kWebrtcAudioPrivate); 746 skip.insert(APIPermission::kWebrtcAudioPrivate);
748 skip.insert(APIPermission::kWebrtcLoggingPrivate); 747 skip.insert(APIPermission::kWebrtcLoggingPrivate);
749 skip.insert(APIPermission::kWebstorePrivate); 748 skip.insert(APIPermission::kWebstorePrivate);
750 749
751 // Warned as part of host permissions. 750 // Warned as part of host permissions.
752 skip.insert(APIPermission::kDevtools); 751 skip.insert(APIPermission::kDevtools);
753 752
754 // Platform apps. 753 // Platform apps.
755 skip.insert(APIPermission::kFileSystem); 754 skip.insert(APIPermission::kFileSystem);
756 skip.insert(APIPermission::kFileSystemProvider); 755 skip.insert(APIPermission::kFileSystemProvider);
(...skipping 703 matching lines...) Expand 10 before | Expand all | Expand 10 after
1460 EXPECT_FALSE(perm_set->IsEmpty()); 1459 EXPECT_FALSE(perm_set->IsEmpty());
1461 1460
1462 perm_set = new PermissionSet(empty_apis, ManifestPermissionSet(), 1461 perm_set = new PermissionSet(empty_apis, ManifestPermissionSet(),
1463 empty_extent, non_empty_extent); 1462 empty_extent, non_empty_extent);
1464 EXPECT_FALSE(perm_set->IsEmpty()); 1463 EXPECT_FALSE(perm_set->IsEmpty());
1465 } 1464 }
1466 1465
1467 TEST(PermissionsTest, ImpliedPermissions) { 1466 TEST(PermissionsTest, ImpliedPermissions) {
1468 URLPatternSet empty_extent; 1467 URLPatternSet empty_extent;
1469 APIPermissionSet apis; 1468 APIPermissionSet apis;
1470 apis.insert(APIPermission::kWebRequest);
1471 apis.insert(APIPermission::kFileBrowserHandler); 1469 apis.insert(APIPermission::kFileBrowserHandler);
1472 EXPECT_EQ(2U, apis.size()); 1470 EXPECT_EQ(1U, apis.size());
1473 1471
1474 scoped_refptr<PermissionSet> perm_set; 1472 scoped_refptr<PermissionSet> perm_set;
1475 perm_set = new PermissionSet(apis, ManifestPermissionSet(), 1473 perm_set = new PermissionSet(apis, ManifestPermissionSet(),
1476 empty_extent, empty_extent); 1474 empty_extent, empty_extent);
1477 EXPECT_EQ(4U, perm_set->apis().size()); 1475 EXPECT_EQ(2U, perm_set->apis().size());
1478 } 1476 }
1479 1477
1480 TEST(PermissionsTest, SyncFileSystemPermission) { 1478 TEST(PermissionsTest, SyncFileSystemPermission) {
1481 scoped_refptr<Extension> extension = LoadManifest( 1479 scoped_refptr<Extension> extension = LoadManifest(
1482 "permissions", "sync_file_system.json"); 1480 "permissions", "sync_file_system.json");
1483 APIPermissionSet apis; 1481 APIPermissionSet apis;
1484 apis.insert(APIPermission::kSyncFileSystem); 1482 apis.insert(APIPermission::kSyncFileSystem);
1485 EXPECT_TRUE(extension->is_platform_app()); 1483 EXPECT_TRUE(extension->is_platform_app());
1486 EXPECT_TRUE(extension->HasAPIPermission(APIPermission::kSyncFileSystem)); 1484 EXPECT_TRUE(extension->HasAPIPermission(APIPermission::kSyncFileSystem));
1487 std::vector<base::string16> warnings = 1485 std::vector<base::string16> warnings =
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
1520 scoped_refptr<const PermissionSet> permissions_dwr( 1518 scoped_refptr<const PermissionSet> permissions_dwr(
1521 extension_dwr->GetActivePermissions()); 1519 extension_dwr->GetActivePermissions());
1522 1520
1523 EXPECT_FALSE(PermissionMessageProvider::Get()-> 1521 EXPECT_FALSE(PermissionMessageProvider::Get()->
1524 IsPrivilegeIncrease(permissions.get(), 1522 IsPrivilegeIncrease(permissions.get(),
1525 permissions_dwr.get(), 1523 permissions_dwr.get(),
1526 extension->GetType())); 1524 extension->GetType()));
1527 } 1525 }
1528 1526
1529 } // namespace extensions 1527 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/common/extensions/permissions/chrome_api_permissions.cc ('k') | chrome/common/extensions_api_resources.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698