Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2283113002: Add -> operators to CFX_CountRef. (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@privatize
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Add -> operators to CFX_CountRef. Allows CFX_CountRefs to behave more like pointers. Rename SetNull() to Clear() for consistency with other ptrs. Change GetPrivateCopy() into MakePrivateCopy() with no return, since the -> operators are clearer than getting an object pointer. Committed: https://pdfium.googlesource.com/pdfium/+/c10c23a2b1999b1cb0354fd4db9837dc63a3d833

Patch Set 1 #

Patch Set 2 : Split COW from get object #

Patch Set 3 : Merge branch 'privatize' into ptr_operators #

Patch Set 4 : Moar -> #

Patch Set 5 : Regenerate patch, rebase off of master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -160 lines) Patch
M core/fpdfapi/fpdf_page/cpdf_allstates.cpp View 1 2 3 5 chunks +38 lines, -33 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_clippath.cpp View 1 3 chunks +6 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_colorstate.cpp View 1 3 chunks +8 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_generalstate.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_pageobject.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_pathobject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_shadingobject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_textobject.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_textstate.cpp View 1 1 chunk +9 lines, -10 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 14 chunks +55 lines, -45 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 3 chunks +6 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_page/include/cpdf_path.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 1 2 3 chunks +14 lines, -14 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M core/fpdftext/cpdf_textpage.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fxcrt/cfx_count_ref_unittest.cpp View 1 1 chunk +6 lines, -3 lines 0 comments Download
M core/fxcrt/include/cfx_count_ref.h View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M core/fxge/ge/cfx_cliprgn.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdf_transformpage.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfeditimg.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/fxedit/fxet_edit.cpp View 1 2 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 20 (16 generated)
Tom Sepez
Lei, next one.
4 years, 3 months ago (2016-08-26 22:12:05 UTC) #7
Lei Zhang
lgtm
4 years, 3 months ago (2016-08-26 23:49:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2283113002/100001
4 years, 3 months ago (2016-08-26 23:52:12 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 23:52:36 UTC) #20
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/c10c23a2b1999b1cb0354fd4db9837dc63a3...

Powered by Google App Engine
This is Rietveld 408576698