Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1387)

Issue 2282483002: Return the correct channelCountMode and channelInterpretation (Closed)

Created:
4 years, 3 months ago by Raymond Toy
Modified:
4 years, 3 months ago
Reviewers:
hongchan
CC:
blink-reviews, chromium-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Return the correct channelCountMode and channelInterpretation Instead of returning the current mode or interpretation, return the value used in the setter. Eventually, the real mode will get set to the desired value. The members m_channelCountMode and m_channelInterpretation are also made private to force use of the setters and getters. A setter is added too so that the internal state is maintained. BUG=636576 TEST=channel-mode-interp-basic.html Committed: https://crrev.com/c307211c34797418cd5ddddd31efb83f5a509d5e Cr-Commit-Position: refs/heads/master@{#416078}

Patch Set 1 #

Patch Set 2 : Define setters for the mode and interpretation #

Messages

Total messages: 20 (10 generated)
Raymond Toy
PTAL.
4 years, 3 months ago (2016-08-25 20:09:56 UTC) #7
Raymond Toy
Ping
4 years, 3 months ago (2016-09-01 16:36:56 UTC) #9
hongchan
On 2016/09/01 16:36:56, Raymond Toy wrote: > Ping Weirdly enough this CL does not show ...
4 years, 3 months ago (2016-09-01 18:56:51 UTC) #10
hongchan
On 2016/09/01 18:56:51, hoch wrote: > On 2016/09/01 16:36:56, Raymond Toy wrote: > > Ping ...
4 years, 3 months ago (2016-09-01 18:57:16 UTC) #11
Raymond Toy
4 years, 3 months ago (2016-09-01 19:52:17 UTC) #13
Raymond Toy
On 2016/09/01 at 18:57:16, hongchan wrote: > On 2016/09/01 18:56:51, hoch wrote: > > On ...
4 years, 3 months ago (2016-09-01 19:53:02 UTC) #14
hongchan
lgtm
4 years, 3 months ago (2016-09-01 20:38:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282483002/20001
4 years, 3 months ago (2016-09-01 20:40:47 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 22:06:12 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 22:09:28 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c307211c34797418cd5ddddd31efb83f5a509d5e
Cr-Commit-Position: refs/heads/master@{#416078}

Powered by Google App Engine
This is Rietveld 408576698