third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp - Issue 2282483002: Return the correct channelCountMode and channelInterpretation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

Issue 2282483002: Return the correct channelCountMode and channelInterpretation (Closed)

Patch Set: Define setters for the mode and interpretation Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/PannerNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp b/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

index 0ee1be9c6bd3993a4eb2798c56c8b9d9c38d35e6..e5042117c0f7b54b8b426113049dcd9a7cc06840 100644

--- a/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

@@ -54,8 +54,8 @@ OfflineAudioDestinationHandler::OfflineAudioDestinationHandler(AudioNode& node,

// Node-specific defaults.

m_channelCount = m_renderTarget->numberOfChannels();

- m_channelCountMode = Explicit;

- m_channelInterpretation = AudioBus::Speakers;

+ setInternalChannelCountMode(Explicit);

+ setInternalChannelInterpretation(AudioBus::Speakers);

}

PassRefPtr<OfflineAudioDestinationHandler> OfflineAudioDestinationHandler::create(AudioNode& node, AudioBuffer* renderTarget)