Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioNode.h

Issue 2282483002: Return the correct channelCountMode and channelInterpretation (Closed)
Patch Set: Define setters for the mode and interpretation Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/AudioNode.h
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioNode.h b/third_party/WebKit/Source/modules/webaudio/AudioNode.h
index a5b08f577b7bbd121eba7cba0aad1d24c515fdce..b73a1160e02a90272a1ca655e47d9c83b6a7a7c6 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioNode.h
+++ b/third_party/WebKit/Source/modules/webaudio/AudioNode.h
@@ -266,10 +266,17 @@ private:
static int s_nodeCount[NodeTypeEnd];
#endif
-protected:
- unsigned m_channelCount;
ChannelCountMode m_channelCountMode;
AudioBus::ChannelInterpretation m_channelInterpretation;
+
+protected:
+ // Set the (internal) channelCountMode and channelInterpretation
+ // accordingly. Use this in the node constructors to set the internal state
+ // correctly if the node uses values different from the defaults.
+ void setInternalChannelCountMode(ChannelCountMode);
+ void setInternalChannelInterpretation(AudioBus::ChannelInterpretation);
+
+ unsigned m_channelCount;
// The new channel count mode that will be used to set the actual mode in the pre or post
// rendering phase.
ChannelCountMode m_newChannelCountMode;

Powered by Google App Engine
This is Rietveld 408576698