Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: third_party/WebKit/Source/modules/webaudio/PannerNode.cpp

Issue 2282483002: Return the correct channelCountMode and channelInterpretation (Closed)
Patch Set: Define setters for the mode and interpretation Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp b/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
index 33a6e0b05d0ed0a7dddc343c8f70b4462711cce9..ce21afd7e6b0ca8c0f27e12a17ee87462540c536 100644
--- a/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
@@ -72,8 +72,8 @@ PannerHandler::PannerHandler(
// Node-specific default mixing rules.
m_channelCount = 2;
- m_channelCountMode = ClampedMax;
- m_channelInterpretation = AudioBus::Speakers;
+ setInternalChannelCountMode(ClampedMax);
+ setInternalChannelInterpretation(AudioBus::Speakers);
// Explicitly set the default panning model here so that the histograms
// include the default value.
@@ -565,7 +565,7 @@ void PannerHandler::setChannelCount(unsigned long channelCount, ExceptionState&
if (channelCount > 0 && channelCount <= 2) {
if (m_channelCount != channelCount) {
m_channelCount = channelCount;
- if (m_channelCountMode != Max)
+ if (internalChannelCountMode() != Max)
updateChannelsForInputs();
}
} else {
@@ -586,7 +586,7 @@ void PannerHandler::setChannelCountMode(const String& mode, ExceptionState& exce
DCHECK(isMainThread());
BaseAudioContext::AutoLocker locker(context());
- ChannelCountMode oldMode = m_channelCountMode;
+ ChannelCountMode oldMode = internalChannelCountMode();
if (mode == "clamped-max") {
m_newChannelCountMode = ClampedMax;

Powered by Google App Engine
This is Rietveld 408576698