Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2282413002: Replaced PassRefPtr copies with moves in Source/core. (Closed)

Created:
4 years, 3 months ago by Bugs Nash
Modified:
4 years, 3 months ago
Reviewers:
Yuta Kitamura
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, blink-worker-reviews_chromium.org, caseq+blink_chromium.org, chromium-reviews, dcheng, devtools-reviews_chromium.org, dglazkov+blink, krit, eae+blinkwatch, falken, f(malita), fs, gavinp+loader_chromium.org, gyuyoung2, horo+watch_chromium.org, Nate Chapin, jchaffraix+rendering, kinuko+watch, kinuko+worker_chromium.org, kinuko+fileapi, kouhei+svg_chromium.org, kozyatinskiy+blink_chromium.org, leviw+renderwatch, loading-reviews_chromium.org, loading-reviews+parser_chromium.org, lushnikov+blink_chromium.org, nhiroki, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney, sof, szager+layoutwatch_chromium.org, tyoshino+watch_chromium.org, tzik, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replaced PassRefPtr copies with moves in Source/core. Only did replace outside of Source/core/animation, which is already handled in https://codereview.chromium.org/2286233002. Part of making PassRefPtr move only, in preparation for the removal of PassRefPtr. BUG=640449 Committed: https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7 Cr-Commit-Position: refs/heads/master@{#416506}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -87 lines) Patch
M third_party/WebKit/Source/core/clipboard/DataObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSPathValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSVariableReferenceValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/invalidation/InvalidationSet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMArrayBuffer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMDataView.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMSharedArrayBuffer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMTypedArray.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/RemoteSecurityContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/MessageEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/PopStateEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/Blob.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fileapi/File.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/File.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/History.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/History.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/ImageInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextCombine.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextFragment.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LayoutItem.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/api/LayoutTextFragmentItem.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/api/LayoutTextItem.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ClipPathOperation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ShapeValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/DedicatedWorkerThread.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/SharedWorkerThread.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Bugs Nash
4 years, 3 months ago (2016-09-05 03:22:45 UTC) #7
Yuta Kitamura
lgtm
4 years, 3 months ago (2016-09-05 06:33:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282413002/20001
4 years, 3 months ago (2016-09-05 06:33:55 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-05 06:38:46 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 06:40:16 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9a9704a3dba1d86cb02f38bc0ecaacde25fa58e7
Cr-Commit-Position: refs/heads/master@{#416506}

Powered by Google App Engine
This is Rietveld 408576698