third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp - Issue 2282413002: Replaced PassRefPtr copies with moves in Source/core.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp

Issue 2282413002: Replaced PassRefPtr copies with moves in Source/core. (Closed)

Patch Set: rebased Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp ('k') | third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp

diff --git a/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp b/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp

index ecfa490533d65703cc607645be3c90fb569a516c..da8967ae676ffcbdafcba1d65ebf949d2c9d669f 100644

--- a/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp

+++ b/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp

@@ -64,7 +64,7 @@ void processMessageOnWorkerGlobalScope(PassRefPtr<SerializedScriptValue> message

{

WorkerGlobalScope* globalScope = toWorkerGlobalScope(scriptContext);

MessagePortArray* ports = MessagePort::entanglePorts(*scriptContext, std::move(channels));

- globalScope->dispatchEvent(MessageEvent::create(ports, message));

+ globalScope->dispatchEvent(MessageEvent::create(ports, std::move(message)));

workerObjectProxy->confirmMessageFromWorkerObject();

workerObjectProxy->startPendingActivityTimer();

}

@@ -128,7 +128,7 @@ void InProcessWorkerMessagingProxy::postMessageToWorkerObject(PassRefPtr<Seriali

return;

MessagePortArray* ports = MessagePort::entanglePorts(*getExecutionContext(), std::move(channels));

- m_workerObject->dispatchEvent(MessageEvent::create(ports, message));

+ m_workerObject->dispatchEvent(MessageEvent::create(ports, std::move(message)));

}

void InProcessWorkerMessagingProxy::postMessageToWorkerGlobalScope(PassRefPtr<SerializedScriptValue> message, std::unique_ptr<MessagePortChannelArray> channels)