third_party/WebKit/Source/core/loader/FrameLoader.cpp - Issue 2282413002: Replaced PassRefPtr copies with moves in Source/core.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2282413002: Replaced PassRefPtr copies with moves in Source/core. (Closed)

Patch Set: rebased Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp ('k') | third_party/WebKit/Source/core/loader/PingLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

index e9022f0fc84e1fb3926171ff9e43fa51cac114f2..ace751665a243d58ae59f40f807f1df087662feb 100644

--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

@@ -730,7 +730,7 @@ void FrameLoader::updateForSameDocumentNavigation(const KURL& newURL, SameDocume

setHistoryItemStateForCommit(type, historyCommitType, sameDocumentNavigationSource == SameDocumentNavigationHistoryApi ? HistoryNavigationType::HistoryApi : HistoryNavigationType::Fragment);

if (sameDocumentNavigationSource == SameDocumentNavigationHistoryApi) {

- m_currentItem->setStateObject(data);

+ m_currentItem->setStateObject(std::move(data));

m_currentItem->setScrollRestorationType(scrollRestorationType);

}

client()->dispatchDidNavigateWithinPage(m_currentItem.get(), historyCommitType, !!initiatingDocument);

@@ -775,7 +775,7 @@ void FrameLoader::loadInSameDocument(const KURL& url, PassRefPtr<SerializedScrip

checkCompleted();

- m_frame->localDOMWindow()->statePopped(stateObject ? stateObject : SerializedScriptValue::nullValue());

+ m_frame->localDOMWindow()->statePopped(stateObject ? std::move(stateObject) : SerializedScriptValue::nullValue());

if (historyLoadType == HistorySameDocumentLoad)

restoreScrollPositionAndViewState();