Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2282283002: [DevTools] Prepare inspector_protocol build to move. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Prepare inspector_protocol build to move. - Do not list inspector_protocol files anywhere outside; - Separate concatenation from compatibility check; - Improve files layout; - Pass path to jinja module to CodeGenerator. BUG=637032 Committed: https://crrev.com/a73483cd5dd6d569d079e7ea43210f8482d12552 Cr-Commit-Position: refs/heads/master@{#415137}

Patch Set 1 #

Patch Set 2 : jinja #

Patch Set 3 : win compile #

Patch Set 4 : NOTREACHED #

Unified diffs Side-by-side diffs Delta from patch set Stats (+370 lines, -3837 lines) Patch
M third_party/WebKit/Source/core/inspector/BUILD.gn View 1 5 chunks +30 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/inspector.gyp View 1 4 chunks +29 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 4 chunks +12 lines, -35 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Allocator_h.template View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Array_h.template View 1 chunk +0 lines, -136 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/BackendCallback_h.template View 1 chunk +0 lines, -24 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/CheckProtocolCompatibility.py View 1 15 chunks +174 lines, -178 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py View 1 2 9 chunks +21 lines, -39 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Collections_h.template View 1 chunk +0 lines, -51 lines 0 comments Download
A third_party/WebKit/Source/platform/inspector_protocol/ConcatenateProtocols.py View 1 chunk +39 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase_cpp.template View 1 chunk +0 lines, -172 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase_h.template View 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport_cpp.template View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/ErrorSupport_h.template View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Exported_h.template View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Forward_h.template View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/FrontendChannel_h.template View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Imported_h.template View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Maybe_h.template View 1 chunk +0 lines, -80 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Object_cpp.template View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Object_h.template View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Parser_cpp.template View 1 chunk +0 lines, -549 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Parser_h.template View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Protocol_cpp.template View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template View 1 chunk +0 lines, -359 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template View 1 chunk +0 lines, -289 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/ValueConversions_h.template View 1 chunk +0 lines, -171 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Values_cpp.template View 1 chunk +0 lines, -407 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/Values_h.template View 1 chunk +0 lines, -246 lines 0 comments Download
D third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version View 1 chunk +0 lines, -483 lines 0 comments Download
A third_party/WebKit/Source/platform/inspector_protocol/inspector_protocol.gni View 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/inspector_protocol/inspector_protocol.gypi View 1 chunk +33 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Allocator_h.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Array_h.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/lib/BackendCallback_h.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Collections_h.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/lib/DispatcherBase_cpp.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/lib/DispatcherBase_h.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/lib/ErrorSupport_cpp.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/lib/ErrorSupport_h.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Forward_h.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/lib/FrontendChannel_h.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Maybe_h.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Object_cpp.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Object_h.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Parser_cpp.template View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Parser_h.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Protocol_cpp.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/lib/ValueConversions_h.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Values_cpp.template View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/lib/Values_h.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/Source/platform/inspector_protocol/sample_expected_errors.json View 1 chunk +7 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/templates/Exported_h.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/templates/Imported_h.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/templates/TypeBuilder_cpp.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/templates/TypeBuilder_h.template View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp View 1 7 chunks +12 lines, -60 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 39 (27 generated)
dgozman
Take a look please.
4 years, 3 months ago (2016-08-27 01:24:07 UTC) #3
pfeldman
lgtm 2
4 years, 3 months ago (2016-08-27 01:45:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282283002/40001
4 years, 3 months ago (2016-08-29 05:31:14 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/131683)
4 years, 3 months ago (2016-08-29 07:12:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282283002/40001
4 years, 3 months ago (2016-08-29 13:56:22 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/131989)
4 years, 3 months ago (2016-08-29 14:33:13 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282283002/40001
4 years, 3 months ago (2016-08-29 16:45:11 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282283002/40001
4 years, 3 months ago (2016-08-29 20:49:13 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282283002/40001
4 years, 3 months ago (2016-08-29 21:21:21 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282283002/60001
4 years, 3 months ago (2016-08-29 23:55:12 UTC) #35
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-30 05:09:26 UTC) #37
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:12:01 UTC) #39
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a73483cd5dd6d569d079e7ea43210f8482d12552
Cr-Commit-Position: refs/heads/master@{#415137}

Powered by Google App Engine
This is Rietveld 408576698