third_party/WebKit/Source/platform/inspector_protocol/lib/Values_cpp.template - Issue 2282283002: [DevTools] Prepare inspector_protocol build to move.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/lib/Values_cpp.template

Issue 2282283002: [DevTools] Prepare inspector_protocol build to move. (Closed)

Patch Set: NOTREACHED Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/lib/ValueConversions_h.template ('k') | third_party/WebKit/Source/platform/inspector_protocol/lib/Values_h.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/lib/Values_cpp.template

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/Values_cpp.template b/third_party/WebKit/Source/platform/inspector_protocol/lib/Values_cpp.template

similarity index 99%

rename from third_party/WebKit/Source/platform/inspector_protocol/Values_cpp.template

rename to third_party/WebKit/Source/platform/inspector_protocol/lib/Values_cpp.template

index 9c5d8cf3f7f3dbca6d5d2355d8384c23f8dae359..1b5cdfee227b082b3d3f3850589054af6278e497 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/Values_cpp.template

+++ b/third_party/WebKit/Source/platform/inspector_protocol/lib/Values_cpp.template

@@ -167,7 +167,7 @@ std::unique_ptr<Value> FundamentalValue::clone() const

case TypeInteger: return FundamentalValue::create(m_integerValue);

case TypeBoolean: return FundamentalValue::create(m_boolValue);

default:

- NOTREACHED();

+ DCHECK(false);

}

return nullptr;

}