Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: third_party/WebKit/Source/core/inspector/BUILD.gn

Issue 2282283002: [DevTools] Prepare inspector_protocol build to move. (Closed)
Patch Set: NOTREACHED Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/inspector.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/BUILD.gn
diff --git a/third_party/WebKit/Source/core/inspector/BUILD.gn b/third_party/WebKit/Source/core/inspector/BUILD.gn
index 93e89e44aff67197ead1a01fa809dbd3a9208466..e272cea84d557a7ba7614dafdc6d0407d15cf224 100644
--- a/third_party/WebKit/Source/core/inspector/BUILD.gn
+++ b/third_party/WebKit/Source/core/inspector/BUILD.gn
@@ -4,6 +4,8 @@
import("//third_party/WebKit/Source/bindings/bindings.gni")
import("//third_party/WebKit/Source/core/core.gni")
+import(
+ "//third_party/WebKit/Source/platform/inspector_protocol/inspector_protocol.gni")
action("instrumentation_sources") {
script = "CodeGeneratorInstrumentation.py"
@@ -34,32 +36,7 @@ action("protocol_sources") {
deps = [
":protocol_version",
]
- sources = [
- "../../platform/inspector_protocol/Allocator_h.template",
- "../../platform/inspector_protocol/Array_h.template",
- "../../platform/inspector_protocol/BackendCallback_h.template",
- "../../platform/inspector_protocol/CodeGenerator.py",
- "../../platform/inspector_protocol/Collections_h.template",
- "../../platform/inspector_protocol/DispatcherBase_cpp.template",
- "../../platform/inspector_protocol/DispatcherBase_h.template",
- "../../platform/inspector_protocol/ErrorSupport_cpp.template",
- "../../platform/inspector_protocol/ErrorSupport_h.template",
- "../../platform/inspector_protocol/Exported_h.template",
- "../../platform/inspector_protocol/Forward_h.template",
- "../../platform/inspector_protocol/FrontendChannel_h.template",
- "../../platform/inspector_protocol/Imported_h.template",
- "../../platform/inspector_protocol/Maybe_h.template",
- "../../platform/inspector_protocol/Object_cpp.template",
- "../../platform/inspector_protocol/Object_h.template",
- "../../platform/inspector_protocol/Parser_cpp.template",
- "../../platform/inspector_protocol/Parser_h.template",
- "../../platform/inspector_protocol/Protocol_cpp.template",
- "../../platform/inspector_protocol/TypeBuilder_cpp.template",
- "../../platform/inspector_protocol/TypeBuilder_h.template",
- "../../platform/inspector_protocol/ValueConversions_h.template",
- "../../platform/inspector_protocol/Values_cpp.template",
- "../../platform/inspector_protocol/Values_h.template",
- ]
+ sources = inspector_protocol_sources
inputs = [
"browser_protocol.json",
"../../platform/v8_inspector/js_protocol.json",
@@ -126,6 +103,8 @@ action("protocol_sources") {
]
args = [
+ "--jinja_dir",
+ rebase_path("../../../../", root_build_dir), # jinja is in chromium's third_party
"--output_base",
rebase_path(blink_core_output_dir, root_build_dir),
"--config",
@@ -133,9 +112,31 @@ action("protocol_sources") {
]
}
+action("protocol_compatibility_check") {
+ script = "../../platform/inspector_protocol/CheckProtocolCompatibility.py"
+
+ inputs = [
+ "browser_protocol.json",
+ "../../platform/v8_inspector/js_protocol.json",
+ ]
+ _stamp = "$blink_core_output_dir/inspector/browser_protocol.stamp"
+ outputs = [
+ _stamp,
+ ]
+
+ args = [
+ "--stamp",
+ rebase_path(_stamp, root_build_dir),
+ rebase_path("browser_protocol.json", root_build_dir),
+ rebase_path("../../platform/v8_inspector/js_protocol.json", root_build_dir),
+ ]
+}
+
action("protocol_version") {
- script =
- "../../platform/inspector_protocol/generate-inspector-protocol-version"
+ deps = [
+ ":protocol_compatibility_check",
+ ]
+ script = "../../platform/inspector_protocol/ConcatenateProtocols.py"
inputs = [
"browser_protocol.json",
@@ -147,9 +148,8 @@ action("protocol_version") {
]
args = [
- "--o",
- rebase_path(output_file, root_build_dir),
rebase_path("browser_protocol.json", root_build_dir),
rebase_path("../../platform/v8_inspector/js_protocol.json", root_build_dir),
+ rebase_path(output_file, root_build_dir),
]
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/inspector.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698