[DevTools] Switch from platform/v8_inspector to v8/v8-inspector.h.

[DevTools] Switch from platform/v8_inspector to v8/v8-inspector.h.

BUG=635948
NOPRESUBMIT=true (for protocol.json)

Committed: https://crrev.com/a91861b31d2119f96f7b4c0d90b9c4b1d4a24120
Cr-Commit-Position: refs/heads/master@{#417361}

[dgozman, 2016-09-06 21:56:44]

dgozman@chromium.org changed reviewers:
+ jochen@chromium.org, machenbach@chromium.org, pfeldman@chromium.org

[dgozman, 2016-09-06 21:56:46]

Could you please take a look? This should be the last large patch.

[pfeldman, 2016-09-06 22:13:16]

LGTM

[Michael Achenbach, 2016-09-07 06:56:23]

lgtm (non-owner)

https://codereview.chromium.org/2295913003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/scripts/compile_frontend.py (right):

https://codereview.chromium.org/2295913003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/scripts/compile_frontend.py:75:
v8_inspector_path = path.join(path.dirname(devtools_path), os.pardir, os.pardir,
os.pardir, 'v8', 'src', 'inspector')
nit: 80 chars. Maybe you should also put a path.normpath around this to get a
new clean abspath?

[jochen (gone - plz use gerrit), 2016-09-07 14:26:03]

lgtm

[dgozman, 2016-09-07 16:41:28]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 16:42:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 16:50:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 16:50:25]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dgozman, 2016-09-07 21:17:07]

https://codereview.chromium.org/2295913003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/scripts/compile_frontend.py (right):

https://codereview.chromium.org/2295913003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/scripts/compile_frontend.py:75:
v8_inspector_path = path.join(path.dirname(devtools_path), os.pardir, os.pardir,
os.pardir, 'v8', 'src', 'inspector')
On 2016/09/07 06:56:23, machenbach (OOO) wrote:
> nit: 80 chars.
blink doesn't enforce 80 chars rule :-)

> Maybe you should also put a path.normpath around this to get a
> new clean abspath?
Done.

[dgozman, 2016-09-07 21:17:25]

Description was changed from

==========
[DevTools] Switch from platform/v8_inspector to v8/v8-inspector.h.

BUG=635948
==========

to

==========
[DevTools] Switch from platform/v8_inspector to v8/v8-inspector.h.

BUG=635948
NOPRESUBMIT=true (for protocol.json)
==========

[dgozman, 2016-09-07 21:21:27]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-09-07 21:21:28]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
pfeldman@chromium.org, machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2295913003/#ps140001
(title: "normpath")

[commit-bot: I haz the power, 2016-09-07 21:22:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 21:33:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 21:33:39]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2016-09-07 23:43:50]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-09-07 23:43:51]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
pfeldman@chromium.org, machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2295913003/#ps160001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-07 23:44:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 23:50:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 23:50:46]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[dgozman, 2016-09-08 00:29:00]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-09-08 00:29:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 04:48:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 04:48:04]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dgozman, 2016-09-08 14:29:19]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-09-08 14:29:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 19:27:04]

Description was changed from

==========
[DevTools] Switch from platform/v8_inspector to v8/v8-inspector.h.

BUG=635948
NOPRESUBMIT=true (for protocol.json)
==========

to

==========
[DevTools] Switch from platform/v8_inspector to v8/v8-inspector.h.

BUG=635948
NOPRESUBMIT=true (for protocol.json)
==========

[commit-bot: I haz the power, 2016-09-08 19:27:06]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-09-08 19:29:00]

Description was changed from

==========
[DevTools] Switch from platform/v8_inspector to v8/v8-inspector.h.

BUG=635948
NOPRESUBMIT=true (for protocol.json)
==========

to

==========
[DevTools] Switch from platform/v8_inspector to v8/v8-inspector.h.

BUG=635948
NOPRESUBMIT=true (for protocol.json)

Committed: https://crrev.com/a91861b31d2119f96f7b4c0d90b9c4b1d4a24120
Cr-Commit-Position: refs/heads/master@{#417361}
==========

[commit-bot: I haz the power, 2016-09-08 19:29:02]

Patchset 9 (id:??) landed as
https://crrev.com/a91861b31d2119f96f7b4c0d90b9c4b1d4a24120
Cr-Commit-Position: refs/heads/master@{#417361}