Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2280723004: services/ui: Remove unwanted gpu dependency from services/ui/surfaces. (Closed)

Created:
4 years, 3 months ago by sadrul
Modified:
4 years, 3 months ago
Reviewers:
Fady Samuel, sky
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

services/ui: Remove unwanted gpu dependency from services/ui/surfaces. //services/ui/surfaces code runs in the window-server, and so should not directly use code in //services/ui/gpu, which should run in the gpu process. BUG=613366 Committed: https://crrev.com/7f41519ba395d7c8ddd346260bb2c497b16c6ebf Cr-Commit-Position: refs/heads/master@{#414810}

Patch Set 1 #

Patch Set 2 : . #

Messages

Total messages: 21 (13 generated)
sadrul
fsamuel@ for ui/surfaces changes. sky@ for ui/ws changes. https://codereview.chromium.org/2281583003/ is the larger CL to refactor ...
4 years, 3 months ago (2016-08-25 23:57:40 UTC) #4
sky
LGTM
4 years, 3 months ago (2016-08-26 16:04:08 UTC) #11
Fady Samuel
lgtm
4 years, 3 months ago (2016-08-26 16:37:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280723004/20001
4 years, 3 months ago (2016-08-26 17:26:16 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/282088)
4 years, 3 months ago (2016-08-26 19:56:44 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280723004/20001
4 years, 3 months ago (2016-08-26 20:10:47 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 21:29:17 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 21:31:48 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7f41519ba395d7c8ddd346260bb2c497b16c6ebf
Cr-Commit-Position: refs/heads/master@{#414810}

Powered by Google App Engine
This is Rietveld 408576698