Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: services/ui/surfaces/display_compositor.cc

Issue 2280723004: services/ui: Remove unwanted gpu dependency from services/ui/surfaces. (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/ui/surfaces/display_compositor.h" 5 #include "services/ui/surfaces/display_compositor.h"
6 6
7 #include "cc/output/copy_output_request.h" 7 #include "cc/output/copy_output_request.h"
8 #include "cc/output/output_surface.h" 8 #include "cc/output/output_surface.h"
9 #include "cc/output/renderer_settings.h" 9 #include "cc/output/renderer_settings.h"
10 #include "cc/output/texture_mailbox_deleter.h" 10 #include "cc/output/texture_mailbox_deleter.h"
11 #include "cc/scheduler/begin_frame_source.h" 11 #include "cc/scheduler/begin_frame_source.h"
12 #include "cc/scheduler/delay_based_time_source.h" 12 #include "cc/scheduler/delay_based_time_source.h"
13 #include "cc/surfaces/display.h" 13 #include "cc/surfaces/display.h"
14 #include "cc/surfaces/display_scheduler.h" 14 #include "cc/surfaces/display_scheduler.h"
15 #include "gpu/ipc/client/gpu_channel_host.h"
15 #include "services/ui/surfaces/direct_output_surface.h" 16 #include "services/ui/surfaces/direct_output_surface.h"
16 #include "services/ui/surfaces/surfaces_context_provider.h" 17 #include "services/ui/surfaces/surfaces_context_provider.h"
17 18
18 #if defined(USE_OZONE) 19 #if defined(USE_OZONE)
19 #include "gpu/command_buffer/client/gles2_interface.h" 20 #include "gpu/command_buffer/client/gles2_interface.h"
20 #include "services/ui/surfaces/direct_output_surface_ozone.h" 21 #include "services/ui/surfaces/direct_output_surface_ozone.h"
21 #endif 22 #endif
22 23
23 namespace ui { 24 namespace ui {
24 25
25 DisplayCompositor::DisplayCompositor( 26 DisplayCompositor::DisplayCompositor(
26 scoped_refptr<base::SingleThreadTaskRunner> task_runner, 27 scoped_refptr<base::SingleThreadTaskRunner> task_runner,
27 gfx::AcceleratedWidget widget, 28 gfx::AcceleratedWidget widget,
29 scoped_refptr<gpu::GpuChannelHost> gpu_channel,
28 const scoped_refptr<SurfacesState>& surfaces_state) 30 const scoped_refptr<SurfacesState>& surfaces_state)
29 : task_runner_(task_runner), 31 : task_runner_(task_runner),
30 surfaces_state_(surfaces_state), 32 surfaces_state_(surfaces_state),
31 factory_(surfaces_state->manager(), this), 33 factory_(surfaces_state->manager(), this),
32 allocator_(surfaces_state->next_client_id()) { 34 allocator_(surfaces_state->next_client_id()) {
33 surfaces_state_->manager()->RegisterSurfaceClientId(allocator_.client_id()); 35 surfaces_state_->manager()->RegisterSurfaceClientId(allocator_.client_id());
34 surfaces_state_->manager()->RegisterSurfaceFactoryClient( 36 surfaces_state_->manager()->RegisterSurfaceFactoryClient(
35 allocator_.client_id(), this); 37 allocator_.client_id(), this);
36 38
39 gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager =
40 gpu_channel->gpu_memory_buffer_manager();
37 scoped_refptr<SurfacesContextProvider> surfaces_context_provider( 41 scoped_refptr<SurfacesContextProvider> surfaces_context_provider(
38 new SurfacesContextProvider(widget)); 42 new SurfacesContextProvider(widget, std::move(gpu_channel)));
39 // TODO(rjkroege): If there is something better to do than CHECK, add it. 43 // TODO(rjkroege): If there is something better to do than CHECK, add it.
40 CHECK(surfaces_context_provider->BindToCurrentThread()); 44 CHECK(surfaces_context_provider->BindToCurrentThread());
41 45
42 std::unique_ptr<cc::SyntheticBeginFrameSource> synthetic_begin_frame_source( 46 std::unique_ptr<cc::SyntheticBeginFrameSource> synthetic_begin_frame_source(
43 new cc::DelayBasedBeginFrameSource( 47 new cc::DelayBasedBeginFrameSource(
44 base::MakeUnique<cc::DelayBasedTimeSource>(task_runner_.get()))); 48 base::MakeUnique<cc::DelayBasedTimeSource>(task_runner_.get())));
45 49
46 std::unique_ptr<cc::OutputSurface> display_output_surface; 50 std::unique_ptr<cc::OutputSurface> display_output_surface;
47 if (surfaces_context_provider->ContextCapabilities().surfaceless) { 51 if (surfaces_context_provider->ContextCapabilities().surfaceless) {
48 #if defined(USE_OZONE) 52 #if defined(USE_OZONE)
49 display_output_surface = base::MakeUnique<DirectOutputSurfaceOzone>( 53 display_output_surface = base::MakeUnique<DirectOutputSurfaceOzone>(
50 surfaces_context_provider, widget, synthetic_begin_frame_source.get(), 54 surfaces_context_provider, widget, synthetic_begin_frame_source.get(),
51 GL_TEXTURE_2D, GL_RGB); 55 gpu_memory_buffer_manager, GL_TEXTURE_2D, GL_RGB);
52 #else 56 #else
53 NOTREACHED(); 57 NOTREACHED();
54 #endif 58 #endif
55 } else { 59 } else {
56 display_output_surface = base::MakeUnique<DirectOutputSurface>( 60 display_output_surface = base::MakeUnique<DirectOutputSurface>(
57 surfaces_context_provider, synthetic_begin_frame_source.get()); 61 surfaces_context_provider, synthetic_begin_frame_source.get());
58 } 62 }
59 63
60 int max_frames_pending = 64 int max_frames_pending =
61 display_output_surface->capabilities().max_frames_pending; 65 display_output_surface->capabilities().max_frames_pending;
62 DCHECK_GT(max_frames_pending, 0); 66 DCHECK_GT(max_frames_pending, 0);
63 67
64 std::unique_ptr<cc::DisplayScheduler> scheduler( 68 std::unique_ptr<cc::DisplayScheduler> scheduler(
65 new cc::DisplayScheduler(synthetic_begin_frame_source.get(), 69 new cc::DisplayScheduler(synthetic_begin_frame_source.get(),
66 task_runner_.get(), max_frames_pending)); 70 task_runner_.get(), max_frames_pending));
67 71
68 display_.reset(new cc::Display( 72 display_.reset(new cc::Display(
69 nullptr /* bitmap_manager */, nullptr /* gpu_memory_buffer_manager */, 73 nullptr /* bitmap_manager */, gpu_memory_buffer_manager,
70 cc::RendererSettings(), std::move(synthetic_begin_frame_source), 74 cc::RendererSettings(), std::move(synthetic_begin_frame_source),
71 std::move(display_output_surface), std::move(scheduler), 75 std::move(display_output_surface), std::move(scheduler),
72 base::MakeUnique<cc::TextureMailboxDeleter>(task_runner_.get()))); 76 base::MakeUnique<cc::TextureMailboxDeleter>(task_runner_.get())));
73 display_->Initialize(this, surfaces_state_->manager(), 77 display_->Initialize(this, surfaces_state_->manager(),
74 allocator_.client_id()); 78 allocator_.client_id());
75 display_->SetVisible(true); 79 display_->SetVisible(true);
76 } 80 }
77 81
78 DisplayCompositor::~DisplayCompositor() { 82 DisplayCompositor::~DisplayCompositor() {
79 surfaces_state_->manager()->UnregisterSurfaceFactoryClient( 83 surfaces_state_->manager()->UnregisterSurfaceFactoryClient(
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 // This notification is not relevant to our client outside of tests. 132 // This notification is not relevant to our client outside of tests.
129 } 133 }
130 134
131 void DisplayCompositor::DisplayDidDrawAndSwap() { 135 void DisplayCompositor::DisplayDidDrawAndSwap() {
132 // This notification is not relevant to our client outside of tests. We 136 // This notification is not relevant to our client outside of tests. We
133 // unblock the client from the DrawCallback when the surface is going to 137 // unblock the client from the DrawCallback when the surface is going to
134 // be drawn. 138 // be drawn.
135 } 139 }
136 140
137 } // namespace ui 141 } // namespace ui
OLDNEW
« no previous file with comments | « services/ui/surfaces/display_compositor.h ('k') | services/ui/surfaces/surfaces_context_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698