Don't apply overflow clips in paint invalidation.

Don't apply overflow clips in paint invalidation.

Previously, such clips were applied if the paint invalidation container did
not scroll overflow, but this is problematic, because overflow:hidden elements
can be scrolled via script.

BUG=597902, 640565
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/537724421c0f5d046e56fb0eba001da3bcea0613
Cr-Commit-Position: refs/heads/master@{#414951}

[chrishtr, 2016-08-26 22:31:45]

Description was changed from

==========
none


none


none

BUG=
==========

to

==========
none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-08-26 22:33:24]

Description was changed from

==========
none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't apply overflow clips in paint invalidation.

Previously, such clips were applied if the paint invalidation container did
not scroll overflow, but this is problematic, because overflow:hidden elements
can be scrolled via script.

BUG=597902
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-08-26 22:36:36]

Description was changed from

==========
Don't apply overflow clips in paint invalidation.

Previously, such clips were applied if the paint invalidation container did
not scroll overflow, but this is problematic, because overflow:hidden elements
can be scrolled via script.

BUG=597902
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't apply overflow clips in paint invalidation.

Previously, such clips were applied if the paint invalidation container did
not scroll overflow, but this is problematic, because overflow:hidden elements
can be scrolled via script.

BUG=597902,597902
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-08-26 22:37:14]

chrishtr@chromium.org changed reviewers:
+ wangxianzhu@chromium.org, wkorman@chromium.org

[chrishtr, 2016-08-26 22:37:15]

This essentially reverts https://codereview.chromium.org/1856993004.

[chrishtr, 2016-08-26 22:37:24]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 22:37:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wkorman, 2016-08-26 22:58:03]

lgtm

The BUG= has the same bug in there 2x, maybe you meant to paste a different bug
for one of those?

https://codereview.chromium.org/2280243002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2280243002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:1028: if (applyOverflowClip
== ApplyNonScrollOverflowClip)
In reviewing the docs for this method to make sure we didn't need to update
them, I saw this:

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/La...

    // If edgeInclusive is true, then this method may return true even
    // if the resulting rect has zero area.

There is no sign of 'edgeInclusive' except in VisualRectFlags which is not a
part of this method. If this just a totally stale comment maybe remove as part
of this change.

[chrishtr, 2016-08-26 23:04:12]

Description was changed from

==========
Don't apply overflow clips in paint invalidation.

Previously, such clips were applied if the paint invalidation container did
not scroll overflow, but this is problematic, because overflow:hidden elements
can be scrolled via script.

BUG=597902,597902
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't apply overflow clips in paint invalidation.

Previously, such clips were applied if the paint invalidation container did
not scroll overflow, but this is problematic, because overflow:hidden elements
can be scrolled via script.

BUG=597902,640565
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-08-26 23:05:18]

https://codereview.chromium.org/2280243002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2280243002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:1028: if (applyOverflowClip
== ApplyNonScrollOverflowClip)
On 2016/08/26 at 22:58:03, wkorman wrote:
> In reviewing the docs for this method to make sure we didn't need to update
them, I saw this:
> 
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/La...
> 
>     // If edgeInclusive is true, then this method may return true even
>     // if the resulting rect has zero area.
> 
> There is no sign of 'edgeInclusive' except in VisualRectFlags which is not a
part of this method. If this just a totally stale comment maybe remove as part
of this change.

See line 1041 in the new file.

[chrishtr, 2016-08-26 23:05:34]

Also, added the correct bug.

[commit-bot: I haz the power, 2016-08-27 00:03:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 00:03:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[wkorman, 2016-08-27 00:32:02]

https://codereview.chromium.org/2280243002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2280243002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:1028: if (applyOverflowClip
== ApplyNonScrollOverflowClip)
On 2016/08/26 23:05:18, chrishtr wrote:
> On 2016/08/26 at 22:58:03, wkorman wrote:
> > In reviewing the docs for this method to make sure we didn't need to update
> them, I saw this:
> > 
> >
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/La...
> > 
> >     // If edgeInclusive is true, then this method may return true even
> >     // if the resulting rect has zero area.
> > 
> > There is no sign of 'edgeInclusive' except in VisualRectFlags which is not a
> part of this method. If this just a totally stale comment maybe remove as part
> of this change.
> 
> See line 1041 in the new file.

May have forgotten to add file or upload

[chrishtr, 2016-08-27 23:53:49]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-08-27 23:53:49]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2280243002/#ps40001
(title: "none")

[commit-bot: I haz the power, 2016-08-27 23:53:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-28 02:16:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-28 02:17:37]

Description was changed from

==========
Don't apply overflow clips in paint invalidation.

Previously, such clips were applied if the paint invalidation container did
not scroll overflow, but this is problematic, because overflow:hidden elements
can be scrolled via script.

BUG=597902,640565
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't apply overflow clips in paint invalidation.

Previously, such clips were applied if the paint invalidation container did
not scroll overflow, but this is problematic, because overflow:hidden elements
can be scrolled via script.

BUG=597902,640565
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/537724421c0f5d046e56fb0eba001da3bcea0613
Cr-Commit-Position: refs/heads/master@{#414951}
==========

[commit-bot: I haz the power, 2016-08-28 02:17:38]

Patchset 3 (id:??) landed as
https://crrev.com/537724421c0f5d046e56fb0eba001da3bcea0613
Cr-Commit-Position: refs/heads/master@{#414951}