Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp

Issue 2280243002: Don't apply overflow clips in paint invalidation. (Closed)
Patch Set: none Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
diff --git a/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp b/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
index 9d380d2dcd495337a1986dfda0b18d4d71cab736..b45503a9952551ae29af17e7412f6123ac37fde3 100644
--- a/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
+++ b/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp
@@ -315,9 +315,9 @@ void PaintInvalidationState::updateForNormalChildren()
if (!box.hasClipRelatedProperty())
return;
- // Do not clip or scroll for the paint invalidation container, if it scrolls overflow, because it will always use composited
- // scrolling in this case.
- if (box == m_paintInvalidationContainer && box.scrollsOverflow()) {
+ // Do not clip or scroll for the paint invalidation container, because the semantics of visual rects do not include clipping or
+ // scrolling on that object.
+ if (box == m_paintInvalidationContainer) {
DCHECK(!m_clipped); // The box establishes paint invalidation container, so no m_clipped inherited.
} else {
// This won't work fully correctly for fixed-position elements, who should receive CSS clip but for whom the current object
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698