Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

Issue 2280243002: Don't apply overflow clips in paint invalidation. (Closed)
Patch Set: none Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp
diff --git a/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp b/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp
index a0ec91f8f141f9f0dd68799d42da8ed32e9224b5..dbda2256b4af0173fa4fe1a5b98eec2263c2aed9 100644
--- a/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp
+++ b/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp
@@ -423,8 +423,8 @@ TEST_F(VisualRectMappingTest, ContainerOverflowHidden)
rect = targetOverflowRect;
EXPECT_TRUE(target->mapToVisualRectInAncestorSpace(container, rect));
- // Rect is clipped by container's overflow clip.
- EXPECT_EQ(LayoutRect(10, 10, 50, 80), rect);
+ // Rect is not clipped by container's overflow clip.
+ EXPECT_EQ(LayoutRect(10, 10, 140, 110), rect);
}
TEST_F(VisualRectMappingTest, ContainerFlippedWritingModeAndOverflowHidden)
@@ -463,8 +463,7 @@ TEST_F(VisualRectMappingTest, ContainerFlippedWritingModeAndOverflowHidden)
target->flipForWritingMode(rect);
EXPECT_TRUE(target->mapToVisualRectInAncestorSpace(container, rect));
// 58 = target_physical_x(100) + container_border_left(40) - scroll_left(58)
- // The other sides of the rect are clipped by container's overflow clip.
- EXPECT_EQ(LayoutRect(58, 10, 32, 80), rect);
+ EXPECT_EQ(LayoutRect(-10, 10, 140, 110), rect);
}
TEST_F(VisualRectMappingTest, ContainerAndTargetDifferentFlippedWritingMode)
« no previous file with comments | « third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698