Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1500)

Issue 2282403002: [MD History] Clear ripple on CBD press. (Closed)

Created:
4 years, 3 months ago by calamity
Modified:
4 years, 3 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Clear ripple on CBD press. This CL fixes an issue where the CBD button would stay grey after the CBD button was activated via spacebar. BUG=640894 NO_DEPENDENCY_CHECKS=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/348a850f2f2999585d354ce729864b578b4c9a36 Cr-Commit-Position: refs/heads/master@{#418807}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/resources/md_history/app.crisper.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/compiled_resources2.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/side_bar.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/side_bar.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 34 (26 generated)
calamity
4 years, 3 months ago (2016-09-02 06:32:49 UTC) #3
Dan Beam
https://codereview.chromium.org/2282403002/diff/1/chrome/browser/resources/md_history/side_bar.html File chrome/browser/resources/md_history/side_bar.html (right): https://codereview.chromium.org/2282403002/diff/1/chrome/browser/resources/md_history/side_bar.html#newcode88 chrome/browser/resources/md_history/side_bar.html:88: <paper-ripple></paper-ripple> you guys should construct these dynamically rather than ...
4 years, 3 months ago (2016-09-02 23:24:51 UTC) #4
tsergeant
lgtm Do you know why this is happening? Is it because a new tab opens ...
4 years, 3 months ago (2016-09-05 23:52:52 UTC) #5
calamity
On 2016/09/05 23:52:52, tsergeant wrote: > lgtm > > Do you know why this is ...
4 years, 3 months ago (2016-09-06 04:05:24 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 2278383002 Patch 20001). Please resolve the dependency and ...
4 years, 3 months ago (2016-09-06 04:05:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282403002/50001
4 years, 3 months ago (2016-09-15 07:42:51 UTC) #30
commit-bot: I haz the power
Committed patchset #3 (id:50001)
4 years, 3 months ago (2016-09-15 08:20:38 UTC) #32
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 08:23:54 UTC) #34
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/348a850f2f2999585d354ce729864b578b4c9a36
Cr-Commit-Position: refs/heads/master@{#418807}

Powered by Google App Engine
This is Rietveld 408576698