|
|
Created:
4 years, 3 months ago by calamity Modified:
4 years, 3 months ago Reviewers:
tsergeant CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD History] Clear ripple on CBD press.
This CL fixes an issue where the CBD button would stay grey after the
CBD button was activated via spacebar.
BUG=640894
NO_DEPENDENCY_CHECKS=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/348a850f2f2999585d354ce729864b578b4c9a36
Cr-Commit-Position: refs/heads/master@{#418807}
Patch Set 1 #
Total comments: 1
Patch Set 2 : rebase #Patch Set 3 : rebase #
Depends on Patchset: Messages
Total messages: 34 (26 generated)
Description was changed from ========== [MD History] Clear ripple on CBD press. This CL fixes an issue where the CBD button would stay grey after the CBD button was activated via spacebar. BUG=640894 ========== to ========== [MD History] Clear ripple on CBD press. This CL fixes an issue where the CBD button would stay grey after the CBD button was activated via spacebar. BUG=640894 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
calamity@chromium.org changed reviewers: + tsergeant@chromium.org
https://codereview.chromium.org/2282403002/diff/1/chrome/browser/resources/md... File chrome/browser/resources/md_history/side_bar.html (right): https://codereview.chromium.org/2282403002/diff/1/chrome/browser/resources/md... chrome/browser/resources/md_history/side_bar.html:88: <paper-ripple></paper-ripple> you guys should construct these dynamically rather than declaratively if performance is important
lgtm Do you know why this is happening? Is it because a new tab opens and eats the up action?
On 2016/09/05 23:52:52, tsergeant wrote: > lgtm > > Do you know why this is happening? Is it because a new tab opens and eats the up > action? It clears the ripple on keyup which ends up happening on the new tab.
The CQ bit was checked by calamity@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2278383002 Patch 20001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
Description was changed from ========== [MD History] Clear ripple on CBD press. This CL fixes an issue where the CBD button would stay grey after the CBD button was activated via spacebar. BUG=640894 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD History] Clear ripple on CBD press. This CL fixes an issue where the CBD button would stay grey after the CBD button was activated via spacebar. BUG=640894 NO_DEPENDENCY_CHECKS=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by calamity@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by calamity@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
The CQ bit was checked by calamity@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
The CQ bit was checked by calamity@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
Patchset #3 (id:30001) has been deleted
The CQ bit was checked by calamity@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tsergeant@chromium.org Link to the patchset: https://codereview.chromium.org/2282403002/#ps50001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [MD History] Clear ripple on CBD press. This CL fixes an issue where the CBD button would stay grey after the CBD button was activated via spacebar. BUG=640894 NO_DEPENDENCY_CHECKS=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD History] Clear ripple on CBD press. This CL fixes an issue where the CBD button would stay grey after the CBD button was activated via spacebar. BUG=640894 NO_DEPENDENCY_CHECKS=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #3 (id:50001)
Message was sent while issue was closed.
Description was changed from ========== [MD History] Clear ripple on CBD press. This CL fixes an issue where the CBD button would stay grey after the CBD button was activated via spacebar. BUG=640894 NO_DEPENDENCY_CHECKS=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD History] Clear ripple on CBD press. This CL fixes an issue where the CBD button would stay grey after the CBD button was activated via spacebar. BUG=640894 NO_DEPENDENCY_CHECKS=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/348a850f2f2999585d354ce729864b578b4c9a36 Cr-Commit-Position: refs/heads/master@{#418807} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/348a850f2f2999585d354ce729864b578b4c9a36 Cr-Commit-Position: refs/heads/master@{#418807} |